Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: tools/json_schema_compiler/cpp_type_generator_test.py

Issue 9309044: Supporting more APIs with json_schema_compiler (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: a few comments, fixes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/cpp_type_generator_test.py
diff --git a/tools/json_schema_compiler/cpp_type_generator_test.py b/tools/json_schema_compiler/cpp_type_generator_test.py
index 155b78844f49de6b11d21a18919d90eb8c1172bf..0abe4bd1281a55cdecf78b18a8d0af92397332aa 100644
--- a/tools/json_schema_compiler/cpp_type_generator_test.py
+++ b/tools/json_schema_compiler/cpp_type_generator_test.py
@@ -23,16 +23,16 @@ class CppTypeGeneratorTest(unittest.TestCase):
'path/to/tabs.json')
self.tabs = self.model.namespaces.get('tabs')
- def testGenerateCppIncludes(self):
+ def testGenerateIncludes(self):
manager = CppTypeGenerator('', self.windows, 'windows_api')
manager.AddNamespace(self.tabs, 'tabs_api')
self.assertEquals('#include "path/to/tabs_api.h"',
- manager.GenerateCppIncludes().Render())
+ manager.GenerateIncludes().Render())
manager = CppTypeGenerator('', self.permissions, 'permissions_api')
manager.AddNamespace(self.permissions, 'permissions_api')
- self.assertEquals('', manager.GenerateCppIncludes().Render())
+ self.assertEquals('', manager.GenerateIncludes().Render())
- def testGenerateCppIncludesMultipleTypes(self):
+ def testGenerateIncludesMultipleTypes(self):
m = model.Model()
self.tabs_json[0]['types'].append(self.permissions_json[0]['types'][0])
tabs_namespace = m.AddNamespace(self.tabs_json[0],
@@ -44,7 +44,7 @@ class CppTypeGeneratorTest(unittest.TestCase):
manager = CppTypeGenerator('', windows, 'windows_api')
manager.AddNamespace(tabs_namespace, 'tabs_api')
self.assertEquals('#include "path/to/tabs_api.h"',
- manager.GenerateCppIncludes().Render())
+ manager.GenerateIncludes().Render())
def testGetTypeSimple(self):
manager = CppTypeGenerator('', self.tabs, 'tabs_api')
@@ -60,7 +60,7 @@ class CppTypeGeneratorTest(unittest.TestCase):
def testGetTypeArray(self):
manager = CppTypeGenerator('', self.windows, 'windows_api')
- self.assertEquals('std::vector<Window>',
+ self.assertEquals('std::vector<linked_ptr<Window> >',
manager.GetType(
self.windows.functions['getAll'].callback.param))
manager = CppTypeGenerator('', self.permissions, 'permissions_api')
@@ -77,7 +77,7 @@ class CppTypeGeneratorTest(unittest.TestCase):
def testGetTypeIncludedRef(self):
manager = CppTypeGenerator('', self.windows, 'windows_api')
manager.AddNamespace(self.tabs, 'tabs_api')
- self.assertEquals('std::vector<tabs_api::Tab>',
+ self.assertEquals('std::vector<linked_ptr<tabs_api::Tab> >',
manager.GetType(
self.windows.types['Window'].properties['tabs']))
@@ -108,18 +108,16 @@ class CppTypeGeneratorTest(unittest.TestCase):
manager = CppTypeGenerator('extensions', self.permissions,
'permissions_api')
self.assertEquals(
- 'namespace extensions {\n'
- 'namespace permissions_api {',
- manager.GetCppNamespaceStart().Render())
+ 'namespace extensions {',
+ manager.GetRootNamespaceStart().Render())
manager = CppTypeGenerator('extensions::gen::api', self.permissions,
'permissions_api')
self.assertEquals(
'namespace extensions {\n'
'namespace gen {\n'
- 'namespace api {\n'
- 'namespace permissions_api {',
- manager.GetCppNamespaceStart().Render())
+ 'namespace api {',
+ manager.GetRootNamespaceStart().Render())
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698