Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/json_schema_compiler/code.py

Issue 9309044: Supporting more APIs with json_schema_compiler (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: a few comments, fixes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/json_schema_compiler/cc_generator.py ('K') | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/compiler.py » ('j') | tools/json_schema_compiler/cpp_type_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/code.py
diff --git a/tools/json_schema_compiler/code.py b/tools/json_schema_compiler/code.py
index 4f2a64b014c8ad56a7da64d7a6d1919027986eb2..1799bc65d0ace248d2b10db12f34b8424ad6601b 100644
--- a/tools/json_schema_compiler/code.py
+++ b/tools/json_schema_compiler/code.py
@@ -38,8 +38,11 @@ class Code(object):
raise TypeError()
assert self is not obj
for line in obj._code:
- # line % () will fail if any substitution tokens are left in line
- self._code.append(((' ' * self._indent_level) + line % ()).rstrip())
+ try:
+ # line % () will fail if any substitution tokens are left in line
+ self._code.append(((' ' * self._indent_level) + line % ()).rstrip())
+ except TypeError:
+ raise TypeError('Unsubstituted value when concatting\n' + line)
return self
« tools/json_schema_compiler/cc_generator.py ('K') | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/compiler.py » ('j') | tools/json_schema_compiler/cpp_type_generator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698