Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9309042: Move FocusTracker to ui/. (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move FocusTracker to ui/. BUG=95573 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -179 lines) Patch
M chrome/browser/tab_contents/moving_to_content/tab_contents_view_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/focus_tracker.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/cocoa/focus_tracker.mm View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/cocoa/focus_tracker_unittest.mm View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A + ui/base/cocoa/focus_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/cocoa/focus_tracker.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/base/cocoa/focus_tracker_unittest.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
We need this in both content and chrome...
8 years, 10 months ago (2012-02-01 22:49:10 UTC) #1
Mark Mentovai
LGTM
8 years, 10 months ago (2012-02-01 22:55:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9309042/1
8 years, 10 months ago (2012-02-01 22:58:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 9309042-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-01 22:58:30 UTC) #4
Avi (use Gerrit)
+ben, sky Who's on the ski trip? Can I get an owner OK?
8 years, 10 months ago (2012-02-01 23:05:18 UTC) #5
Ben Goodger (Google)
LGTM.
8 years, 10 months ago (2012-02-02 01:06:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9309042/1
8 years, 10 months ago (2012-02-02 05:30:42 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-02 07:49:13 UTC) #8 
Change committed as 120177

Powered by Google App Engine
This is Rietveld 408576698