Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 9309008: Initialized the variables root and ri. (Closed)

Created:
8 years, 10 months ago by asharif1
Modified:
8 years, 9 months ago
Reviewers:
Joe, kkania
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Initialized the variables root and ri. These were being flagged by gcc-4.6.0 using the Wmaybe-uninitialized warning. BUG=none TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124619

Patch Set 1 #

Patch Set 2 : Updated README and diff file. #

Patch Set 3 : Rebased patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M third_party/mongoose/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mongoose/chrome-mongoose-modifications.diff View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/mongoose/mongoose.c View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
asharif1
PTAL. This will have to be patched in upstream Mongoose as well.
8 years, 10 months ago (2012-01-31 19:41:01 UTC) #1
kkania
can you update the bottom of the README and the .diff file too?
8 years, 10 months ago (2012-01-31 20:41:44 UTC) #2
Joe
I sent a patch to the team that maintains the Mongoose project. On Tue, Jan ...
8 years, 10 months ago (2012-01-31 21:29:34 UTC) #3
Joe
According to the mongoose team if next_option() returns non-NULL, it guarantees to fill vector correctly. ...
8 years, 10 months ago (2012-01-31 22:03:16 UTC) #4
asharif1
On 2012/01/31 22:03:16, Joe wrote: > According to the mongoose team if next_option() returns non-NULL, ...
8 years, 10 months ago (2012-02-01 05:22:29 UTC) #5
kkania
LGTM; we will eventually update mongoose again, but that is a lower priority item
8 years, 10 months ago (2012-02-02 22:28:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asharif@chromium.org/9309008/5003
8 years, 10 months ago (2012-02-02 23:56:53 UTC) #7
commit-bot: I haz the power
Try job failure for 9309008-5003 (retry) (retry) on win_rel for step "test_shell_tests". It's a second ...
8 years, 10 months ago (2012-02-03 02:49:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asharif@chromium.org/9309008/5003
8 years, 10 months ago (2012-02-03 03:55:01 UTC) #9
commit-bot: I haz the power
Try job failure for 9309008-5003 (retry) on win_rel for step "content_unittests". It's a second try, ...
8 years, 10 months ago (2012-02-03 05:32:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asharif@chromium.org/9309008/5003
8 years, 9 months ago (2012-03-01 22:25:20 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 08:31:18 UTC) #12
Change committed as 124619

Powered by Google App Engine
This is Rietveld 408576698