Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 9309004: Fix PipelineIntegrationTest so it can't hang on decoder errors. (Closed)

Created:
8 years, 10 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 10 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Fix PipelineIntegrationTest so it can't hang on decoder errors. BUG=109875 TEST=PipelineIntegrationTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119973

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address CR comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -36 lines) Patch
M media/filters/pipeline_integration_test.cc View 1 12 chunks +54 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
This fixes the problem, but it feels like there is a readability cost. I'm open ...
8 years, 10 months ago (2012-01-31 18:10:37 UTC) #1
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/9309004/diff/1/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): http://codereview.chromium.org/9309004/diff/1/media/filters/pipeline_integration_test.cc#newcode108 media/filters/pipeline_integration_test.cc:108: error_status_(PIPELINE_OK) { since it can hold OK, s/error_/pipeline_/
8 years, 10 months ago (2012-01-31 19:06:54 UTC) #2
Ami GONE FROM CHROMIUM
LGTM mod that nit.
8 years, 10 months ago (2012-01-31 19:07:02 UTC) #3
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/9309004/diff/1/media/filters/pipeline_integration_test.cc File media/filters/pipeline_integration_test.cc (right): http://codereview.chromium.org/9309004/diff/1/media/filters/pipeline_integration_test.cc#newcode108 media/filters/pipeline_integration_test.cc:108: error_status_(PIPELINE_OK) { On 2012/01/31 19:06:54, Ami Fischman wrote: > ...
8 years, 10 months ago (2012-01-31 19:16:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/9309004/4001
8 years, 10 months ago (2012-01-31 20:19:15 UTC) #5
commit-bot: I haz the power
Change committed as 119973
8 years, 10 months ago (2012-01-31 22:28:14 UTC) #6
Brad Chen
8 years, 10 months ago (2012-01-31 23:21:24 UTC) #7
We're still seeing failures. See
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20UI%2...

On 2012/01/31 22:28:14, I haz the power (commit-bot) wrote:
> Change committed as 119973

Powered by Google App Engine
This is Rietveld 408576698