Removes the use of Windows-specific types for accessibility roles and states ...

Removes the use of Windows-specific types for accessibility roles and states in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14689

[jcampan, 2009-04-24 17:34:16]

http://codereview.chromium.org/93085/diff/1019/78
File chrome/browser/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/93085/diff/1019/78#newcode599
Line 599: // far as MSAA and the UI tests are concerned.
MSAA -> accessibility

http://codereview.chromium.org/93085/diff/1019/73
File chrome/browser/views/tab_contents_container_view.h (right):

http://codereview.chromium.org/93085/diff/1019/73#newcode50
Line 50: bool GetAccessibleRole(AccessibilityTypes::Role* role);
Since this is overridden from View, may be you should move this to the
"Overridden from View" section above?
Also, make it virtual.

http://codereview.chromium.org/93085/diff/1019/70
File chrome/browser/views/toolbar_view.h (right):

http://codereview.chromium.org/93085/diff/1019/70#newcode97
Line 97: void SetAccessibleName(const std::wstring& name);
Why not virtual anymore?
May be you could move them with the rest of the View override above?

http://codereview.chromium.org/93085/diff/1019/82
File chrome/common/accessibility_types.h (right):

http://codereview.chromium.org/93085/diff/1019/82#newcode40
Line 40: };
May be you could add a private constructor to ensure nobody creates an instance
of this class by mistake, since it never supposed to be instanciated.

http://codereview.chromium.org/93085/diff/1019/94
File chrome/views/controls/button/button.h (left):

http://codereview.chromium.org/93085/diff/1019/94#oldcode34
Line 34: // Overridden from View:
Why remove this comment?

http://codereview.chromium.org/93085/diff/1019/96
File chrome/views/controls/button/button_dropdown.h (right):

http://codereview.chromium.org/93085/diff/1019/96#newcode30
Line 30: bool GetAccessibleState(AccessibilityTypes::State* state);
These methods should be virtual.

http://codereview.chromium.org/93085/diff/1019/92
File chrome/views/controls/button/menu_button.h (right):

http://codereview.chromium.org/93085/diff/1019/92#newcode59
Line 59: bool GetAccessibleState(AccessibilityTypes::State* state);
These methods should be virtual.

http://codereview.chromium.org/93085/diff/1019/89
File chrome/views/controls/label.h (right):

http://codereview.chromium.org/93085/diff/1019/89#newcode170
Line 170: bool GetAccessibleState(AccessibilityTypes::State* state);
These methods should be virtual.

http://codereview.chromium.org/93085/diff/1019/84
File chrome/views/widget/root_view.h (right):

http://codereview.chromium.org/93085/diff/1019/84#newcode194
Line 194: void SetAccessibleName(const std::wstring& name);
These methods should be virtual.

[jcampan, 2009-04-24 19:28:48]

http://codereview.chromium.org/93085/diff/119/132
File chrome/common/accessibility_types.h (right):

http://codereview.chromium.org/93085/diff/119/132#newcode45
Line 45: ~AccessibilityTypes();
You should probably provide an empty body for these 2.

http://codereview.chromium.org/93085/diff/119/144
File chrome/views/controls/button/button.h (right):

http://codereview.chromium.org/93085/diff/119/144#newcode70
Line 70: bool hot_tracked_;
Why was this introduced?

[jcampan, 2009-04-24 21:23:39]

LGTM