Fix for minimum size check

Fix for minimum size check

cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t)

[Evan Martin, 2009-04-23 20:43:15]

Carlos, this seems like something you'd like to look at.  If it looks good to
you I'm happy to land it.

[Evan Martin, 2009-04-23 20:46:37]

Looks good to me, minor comments below.

http://codereview.chromium.org/93078/diff/1/2
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/93078/diff/1/2#newcode173
Line 173: static const int min_message_size = 7;
Could you add a comment saying this number comes from the length of "START\0\0"?

http://codereview.chromium.org/93078/diff/1/2#newcode175
Line 175: cds->cbData % sizeof(wchar_t) != 0) {
4 spaces here

[Nikita Ofitserov, 2009-04-23 20:53:43]

On 2009/04/23 20:46:37, Evan Martin wrote:
> Looks good to me, minor comments below.
> 
> http://codereview.chromium.org/93078/diff/1/2
> File chrome/browser/process_singleton_win.cc (right):
> 
> http://codereview.chromium.org/93078/diff/1/2#newcode173
> Line 173: static const int min_message_size = 7;
> Could you add a comment saying this number comes from the length of
"START\0\0"?
Done.

> 
> http://codereview.chromium.org/93078/diff/1/2#newcode175
> Line 175: cds->cbData % sizeof(wchar_t) != 0) {
> 4 spaces here
Done.

[cpu_(ooo_6.6-7.5), 2009-04-24 05:04:18]

LGTM

http://codereview.chromium.org/93078/diff/1003/1004
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/93078/diff/1003/1004#newcode180
Line 180: 
can you please add a check for cds->lpData not being NULL
right before we construct msg string?

[Nikita Ofitserov, 2009-04-24 14:23:52]

On 2009/04/24 05:04:18, cpu wrote:
> LGTM
> 
> http://codereview.chromium.org/93078/diff/1003/1004
> File chrome/browser/process_singleton_win.cc (right):
> 
> http://codereview.chromium.org/93078/diff/1003/1004#newcode180
> Line 180: 
> can you please add a check for cds->lpData not being NULL
> right before we construct msg string?

Done.