Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 9307110: Rename _large.grd to _2x.grd (Closed)

Created:
8 years, 10 months ago by Nico
Modified:
8 years, 10 months ago
CC:
chromium-reviews, pam+watch_chromium.org, Ben Goodger (Google), Emmanuel Saint-loubert-BiƩ, oshima
Visibility:
Public.

Description

Rename _large.grd to _2x.grd BUG=111101 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -270 lines) Patch
A + chrome/app/theme/theme_resources_2x.grd View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/app/theme/theme_resources_large.grd View 1 chunk +0 lines, -179 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/chrome_repack_theme_resources_2x.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/chrome_repack_theme_resources_large.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/chrome_resources.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gritsettings/resource_ids View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/resources/ui_resources_2x.grd View 1 chunk +5 lines, -5 lines 0 comments Download
D ui/resources/ui_resources_large.grd View 1 chunk +0 lines, -45 lines 0 comments Download
M ui/resources/ui_resources_standard.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_resources.gypi View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
8 years, 10 months ago (2012-02-05 04:06:07 UTC) #1
sail
LGTM! You'll need sky or ben to do an owners review too.
8 years, 10 months ago (2012-02-06 15:00:10 UTC) #2
Nico
+ben for OWNERS
8 years, 10 months ago (2012-02-06 15:16:20 UTC) #3
Ben Goodger (Google)
LGTM On Mon, Feb 6, 2012 at 7:16 AM, <thakis@chromium.org> wrote: > +ben for OWNERS ...
8 years, 10 months ago (2012-02-06 19:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9307110/1
8 years, 10 months ago (2012-02-06 19:54:47 UTC) #5
commit-bot: I haz the power
Try job failure for 9307110-1 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 22:20:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9307110/1
8 years, 10 months ago (2012-02-06 22:23:23 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-07 10:37:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9307110/1
8 years, 10 months ago (2012-02-07 16:20:46 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 22:13:57 UTC) #10
Change committed as 120838

Powered by Google App Engine
This is Rietveld 408576698