Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 9307099: chromeos/aura: Make login screen status area font non-bold. (Closed)

Created:
8 years, 10 months ago by Daniel Erat
Modified:
8 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

chromeos/aura: Make login screen status area font non-bold. This removes StatusAreaButton::Delegate's GetStatusAreaFont() method and updates the text styles returned by GetStatusAreaTextStyle() to include the font weight. I'm also removing the translucency from the light gray text style so it'll match the header text on the WebUI login page. BUG=111364 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120756

Patch Set 1 #

Patch Set 2 : update test #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -52 lines) Patch
M chrome/browser/chromeos/frame/browser_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura_browsertest.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
8 years, 10 months ago (2012-02-03 23:57:07 UTC) #1
DaveMoore
lgtm
8 years, 10 months ago (2012-02-05 21:44:10 UTC) #2
Daniel Erat
8 years, 10 months ago (2012-02-06 15:57:14 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 10 months ago (2012-02-06 20:10:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9307099/4001
8 years, 10 months ago (2012-02-06 20:49:58 UTC) #5
commit-bot: I haz the power
Try job failure for 9307099-4001 (retry) on mac_rel for steps "browser_tests, ui_tests". It's a second ...
8 years, 10 months ago (2012-02-06 23:28:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9307099/14001
8 years, 10 months ago (2012-02-07 00:39:05 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 10:22:08 UTC) #8
Change committed as 120756

Powered by Google App Engine
This is Rietveld 408576698