Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: net/http/http_auth_controller_unittest.cc

Issue 9307093: Don't use IDENT_SRC_URL for HttpAuth challenges. IE hasn't supported it for years, and at worst ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_controller_unittest.cc
===================================================================
--- net/http/http_auth_controller_unittest.cc (revision 120359)
+++ net/http/http_auth_controller_unittest.cc (working copy)
@@ -71,8 +71,9 @@
new HttpAuthController(HttpAuth::AUTH_PROXY,
GURL("http://example.com"),
&dummy_auth_cache, &auth_handler_factory));
- ASSERT_EQ(OK,
- controller->HandleAuthChallenge(headers, false, false, dummy_log));
+ ASSERT_EQ(OK, controller->HandleAuthChallenge(
+ headers, HttpAuthController::CHALLENGE_OPTION_SEND_SERVER_AUTH,
+ dummy_log));
ASSERT_TRUE(controller->HaveAuthHandler());
controller->ResetAuth(AuthCredentials());
EXPECT_TRUE(controller->HaveAuth());
@@ -208,8 +209,9 @@
new HttpAuthController(HttpAuth::AUTH_SERVER,
GURL("http://example.com"),
&dummy_auth_cache, &auth_handler_factory));
- ASSERT_EQ(OK,
- controller->HandleAuthChallenge(headers, false, false, dummy_log));
+ ASSERT_EQ(OK, controller->HandleAuthChallenge(
+ headers, HttpAuthController::CHALLENGE_OPTION_SEND_SERVER_AUTH,
+ dummy_log));
ASSERT_TRUE(controller->HaveAuthHandler());
controller->ResetAuth(AuthCredentials());
EXPECT_TRUE(controller->HaveAuth());
@@ -221,8 +223,9 @@
// Once a token is generated, simulate the receipt of a server response
// indicating that the authentication attempt was rejected.
- ASSERT_EQ(OK,
- controller->HandleAuthChallenge(headers, false, false, dummy_log));
+ ASSERT_EQ(OK, controller->HandleAuthChallenge(
+ headers, HttpAuthController::CHALLENGE_OPTION_SEND_SERVER_AUTH,
+ dummy_log));
ASSERT_TRUE(controller->HaveAuthHandler());
controller->ResetAuth(AuthCredentials(ASCIIToUTF16("Hello"), string16()));
EXPECT_TRUE(controller->HaveAuth());

Powered by Google App Engine
This is Rietveld 408576698