Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 9307062: Do not use setDartFlags API as we're now passing flags by other means. (Closed)

Created:
8 years, 10 months ago by antonm
Modified:
8 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, pam+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Do not use setDartFlags API as we're now passing flags by other means. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
antonm
8 years, 10 months ago (2012-02-02 15:26:33 UTC) #1
darin (slow to review)
LGTM
8 years, 10 months ago (2012-02-02 17:47:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antonm@chromium.org/9307062/1
8 years, 10 months ago (2012-02-02 17:49:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 9307062-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-02 17:49:40 UTC) #4
Anton Muhin
+ Avi and Joi for content/public part.
8 years, 10 months ago (2012-02-02 17:51:18 UTC) #5
Avi (use Gerrit)
lgtm
8 years, 10 months ago (2012-02-02 18:45:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antonm@chromium.org/9307062/1
8 years, 10 months ago (2012-02-02 18:49:13 UTC) #7
commit-bot: I haz the power
Try job failure for 9307062-1 (retry) on win_rel for step "test_shell_tests". It's a second try, ...
8 years, 10 months ago (2012-02-02 21:13:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antonm@chromium.org/9307062/1
8 years, 10 months ago (2012-02-03 12:20:54 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-03 13:39:47 UTC) #10
Change committed as 120323

Powered by Google App Engine
This is Rietveld 408576698