Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 9307017: Make change button first run bubble not be default (Closed)

Created:
8 years, 10 months ago by sail
Modified:
8 years, 10 months ago
Reviewers:
msw, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Make change button in first run bubble not be default xib changes: Cleared the "Key Equiv" field from the Change button. BUG=112204 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/nibs/FirstRunBubble.xib View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sail
msw: first run stuff thakis: nibs/* OWNERS
8 years, 10 months ago (2012-01-31 23:13:09 UTC) #1
msw
LGTM, I guess (hard to tell from xib diff).
8 years, 10 months ago (2012-01-31 23:16:35 UTC) #2
Nico
Please add "xib changes:" section to the CL description when doing xib changes.
8 years, 10 months ago (2012-01-31 23:27:26 UTC) #3
sail
On 2012/01/31 23:27:26, Nico wrote: > Please add "xib changes:" section to the CL description ...
8 years, 10 months ago (2012-01-31 23:32:48 UTC) #4
Nico
lgTM A+ cl description, would read again
8 years, 10 months ago (2012-01-31 23:35:01 UTC) #5
sail
On 2012/01/31 23:35:01, Nico wrote: > lgTM > > A+ cl description, would read again ...
8 years, 10 months ago (2012-01-31 23:47:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9307017/1
8 years, 10 months ago (2012-01-31 23:47:44 UTC) #7
Nico
On 2012/01/31 23:47:30, sail wrote: > On 2012/01/31 23:35:01, Nico wrote: > > lgTM > ...
8 years, 10 months ago (2012-01-31 23:59:00 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 01:36:59 UTC) #9
Change committed as 120002

Powered by Google App Engine
This is Rietveld 408576698