Make task_manager_resource_providers.cc compile on POSIX.

Make task_manager_resource_providers.cc compile on POSIX.

TEST=Make sure that the task manager isn't obviously broken on Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14934

[Paweł Hajdan Jr., 2009-04-23 13:46:30]

Please review:

Dean: everything
skylined: I'm not sure about security impact of my changes in
process_util_win.cc. If we pass the process handles to untrusted parties it's
certainly bad. What do you think?

[Dean McNamee, 2009-04-23 13:53:55]

I think Carlos or Nicolas would better know the handle question.

Basically in order to port this code, all handlers now open with VM_READ.  I
don't know how process handlers are used, or how we want to do this.

[Paweł Hajdan Jr., 2009-04-23 13:59:09]

Just a note: it's not a big problem for porting if we can't have VM_READ in
generic OpenProcessHandle function. It should be simple to add a
OpenPriviledgedProcessHandle function or something, but I wouldn't want to
complicate file_utils.h without asking first.

[cpu_(ooo_6.6-7.5), 2009-04-23 17:05:39]

Yes please, add another function as you suggest. Our current use does not have
an issue but somebody in the future might use it by mistake since it lives in
base/


On 2009/04/23 13:59:09, Paweł Hajdan Jr. wrote:
> Just a note: it's not a big problem for porting if we can't have VM_READ in
> generic OpenProcessHandle function. It should be simple to add a
> OpenPriviledgedProcessHandle function or something, but I wouldn't want to
> complicate file_utils.h without asking first.

[Paweł Hajdan Jr., 2009-04-27 08:14:48]

Done. I plan to move even more additional permissions from OpenProcessHandle to
OpenPrivilegedProcessHandle, but to not hold this change for too long, moving
only VM_READ for now.

cpu: Please confirm if now it's ok.
nsylvain: Please look at rest of code changes.

[Nicolas Sylvain, 2009-04-27 14:59:56]

lgtm

[Paweł Hajdan Jr., 2009-04-28 07:06:22]

cpu: ping.

[Paweł Hajdan Jr., 2009-04-30 09:00:28]

cpu: If you have further comments, I'll do them in a follow-up.