Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: content/common/view_messages.h

Issue 9302022: WebWidgetClient::screenInfo() no longer does a synchronous IPC. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Updated based on jam's comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 4ae241a021f2722158f66b83cb2a5913d83d3090..944293a0c546a64d1cf28845add82eaf0eafba47 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -625,6 +625,9 @@ IPC_STRUCT_BEGIN(ViewMsg_New_Params)
// existing navigation that might be loaded in the view. Page IDs are unique
// to a view and are only updated by the renderer after this initial value.
IPC_STRUCT_MEMBER(int32, next_page_id)
+
+ // The properties of the screen associated with the view.
+ IPC_STRUCT_MEMBER(WebKit::WebScreenInfo, screen_info)
IPC_STRUCT_END()
// Messages sent from the browser to the renderer.
@@ -1646,13 +1649,6 @@ IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LoadFont,
uint32 /* font id */)
#endif
-// Returns WebScreenInfo corresponding to the view.
-// TODO(shess): Provide a mapping from reply_msg->routing_id() to
-// HWND so that we can eliminate the NativeViewId parameter.
-IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_GetScreenInfo,
- gfx::NativeViewId /* view */,
- WebKit::WebScreenInfo /* results */)
-
// Send the tooltip text for the current mouse position to the browser.
IPC_MESSAGE_ROUTED2(ViewHostMsg_SetTooltipText,
string16 /* tooltip text string */,

Powered by Google App Engine
This is Rietveld 408576698