Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4497)

Unified Diff: ash/test/test_shell_delegate.cc

Issue 9301016: add compact layout manager window transition unittest. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/compact_layout_manager.h » ('j') | ash/wm/compact_layout_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/test/test_shell_delegate.cc
diff --git a/ash/test/test_shell_delegate.cc b/ash/test/test_shell_delegate.cc
index 53f6913d13d3ed2a7f1e0262dace27279d58032b..0da693a2e10b2a56131d92533057a02cb5e62cb0 100644
--- a/ash/test/test_shell_delegate.cc
+++ b/ash/test/test_shell_delegate.cc
@@ -44,11 +44,13 @@ std::vector<aura::Window*> TestShellDelegate::GetCycleWindowList(
CycleOrder order) const {
// We just use the Shell's default container of windows, so tests can be
// written with the usual CreateTestWindowWithId() calls. But window cycling
- // expects the topmost window at the front of the list, so reverse the order.
+ // expects the topmost window at the front of the list, so reverse the order
+ // if we are mimicing MRU.
James Cook 2012/01/30 22:12:20 nit: mimicing -> mimicking
alicet1 2012/01/30 23:52:53 Done.
aura::Window* default_container = Shell::GetInstance()->GetContainer(
internal::kShellWindowId_DefaultContainer);
std::vector<aura::Window*> windows = default_container->children();
- std::reverse(windows.begin(), windows.end());
+ if (order != ShellDelegate::ORDER_LINEAR)
+ std::reverse(windows.begin(), windows.end());
return windows;
}
« no previous file with comments | « no previous file | ash/wm/compact_layout_manager.h » ('j') | ash/wm/compact_layout_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698