Adding hidden values always turned the object slow case because the...

Adding hidden values always turned the object slow case because the
hidden symbol is not an identifier.  Make sure to keep objects fast
case when adding hidden values if possible.

Committed: http://code.google.com/p/v8/source/detail?r=1758

[Lasse Reichstein, 2009-04-22 06:57:43]

http://codereview.chromium.org/93004/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/93004/diff/1/2#newcode5178
Line 5178: // hash code is zero it will always occupy the first entry if
present.
Maybe make a comment mentioning that an actual string never hashes to zero.

[Erik Corry, 2009-04-22 07:16:15]

LGTM.  The fact that V8 puts the object into slow case when you use a property
name that isn't also a valid identifier is a little subtle.

[Mads Ager (chromium), 2009-04-22 07:37:22]

That is indeed subtle and maybe we should play with that a bit.  The
consequences are not 100% clear to me.

I added a bit to the comment to state that no other string has hash code zero.