aura: Make Linux UI text rendering match GTK Chrome OS.

aura: Make Linux UI text rendering match GTK Chrome OS.

The non-GTK path was previously just using Cairo's default
settings for antialiasing, subpixel order, and hinting.
This change hardcodes the settings to match those currently
loaded from GtkSettings on non-Aura Chrome OS.

BUG=111395
TEST=manual inspection


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119961

[Daniel Erat, 2012-01-30 02:08:06]

Note that I'm intentionally avoiding any changes to the GTK path, which is still
(probably non-optimally) falling back to Cairo's default settings if a settings
daemon isn't running.  Font configuration on Linux is a mess (see Evan's
http://neugierig.org/software/chromium/fonts/).  No one is currently complaining
to me about font configuration in the GTK port and I'd like to keep it that way.

[xji, 2012-01-30 21:37:17]

I am not familiar with this piece of code. It was moved (and kept functionality)
from canvas_skia_linux.cc to pango_util.cc by me.

The change looks reasonable to me. And I guess you get the setting values used
for GTK Chrome OS build by debugging?

LGTM. But it is better to ask some one (Behdad, Jungshik?) who is more familiar
with those settings to double check.

[Daniel Erat, 2012-01-30 21:39:52]

On 2012/01/30 21:37:17, xji wrote:
> I am not familiar with this piece of code. It was moved (and kept
functionality)
> from canvas_skia_linux.cc to pango_util.cc by me.
> 
> The change looks reasonable to me. And I guess you get the setting values used
> for GTK Chrome OS build by debugging?

Yes, I wrote a small program to dump the font-rendering-related settings from
GtkSettings and ran it on a Chrome OS device.

> LGTM. But it is better to ask some one (Behdad, Jungshik?) who is more
familiar
> with those settings to double check.

Thanks, will do.

[jungshik at Google, 2012-01-31 18:45:05]

On 2012/01/30 21:40:06, Daniel Erat wrote:

LGTM

[Ben Goodger (Google), 2012-01-31 19:03:04]

lgtm

[commit-bot: I haz the power, 2012-01-31 19:13:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/9296042/1

[commit-bot: I haz the power, 2012-01-31 21:29:42]

Change committed as 119961