Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: content/public/browser/download_manager.h

Issue 9296012: Hooked up NetLog to DownloadItem, DownloadFile, and FileStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create DownloadItem's BoundNetLog closer to constructor Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index 52a5437b9044c8a4a205f06702c475ef9aed3428..28e1ea23db00d01b6e573286c2b05bb36b77fca4 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -40,6 +40,7 @@
#include "content/public/browser/download_id.h"
#include "content/public/browser/download_item.h"
#include "content/public/browser/browser_thread.h"
+#include "net/base/net_log.h"
#include "net/base/net_errors.h"
class DownloadFileManager;
@@ -51,6 +52,10 @@ struct DownloadCreateInfo;
struct DownloadRetrieveInfo;
struct DownloadSaveInfo;
+namespace net {
+class NetLog;
+} // namespace net
Randy Smith (Not in Mondays) 2012/02/07 23:21:31 You don't need the terminal comment if it's this s
ahendrickson 2012/02/07 23:58:54 Removed.
+
namespace content {
class BrowserContext;
class DownloadManagerDelegate;
@@ -64,7 +69,8 @@ class CONTENT_EXPORT DownloadManager
virtual ~DownloadManager() {}
static DownloadManager* Create(
- DownloadManagerDelegate* delegate);
+ DownloadManagerDelegate* delegate,
+ net::NetLog* net_log);
// Shutdown the download manager. Must be called before destruction.
virtual void Shutdown() = 0;
@@ -206,7 +212,7 @@ class CONTENT_EXPORT DownloadManager
virtual FilePath LastDownloadPath() = 0;
// Creates the download item. Must be called on the UI thread.
- virtual void CreateDownloadItem(
+ virtual net::BoundNetLog CreateDownloadItem(
Randy Smith (Not in Mondays) 2012/02/07 23:19:14 Could you document the return value?
ahendrickson 2012/02/07 23:58:54 Done.
DownloadCreateInfo* info,
const DownloadRequestHandle& request_handle) = 0;

Powered by Google App Engine
This is Rietveld 408576698