Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9296002: Add StringToSizeT to base/string_number_conversions. (Closed)

Created:
8 years, 11 months ago by not at google - send to devlin
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

(re-land) Add StringToSizeT to base/string_number_conversions. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119540 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119585

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove uint* #

Patch Set 4 : re-land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/string_number_conversions.h View 1 3 1 chunk +3 lines, -0 lines 0 comments Download
M base/string_number_conversions.cc View 1 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
Hey Evan So http://crrev.com/119150 added StringToUint(64), but what I really wanted was StringToSizeT, and turns ...
8 years, 11 months ago (2012-01-27 06:25:05 UTC) #1
Evan Martin
Yeah, pre-LGTM on adding these and removing the other ones
8 years, 11 months ago (2012-01-27 16:19:02 UTC) #2
not at google - send to devlin
Defeated! r119525 started using it :( Oh man, this is the hardest to submit trivial ...
8 years, 11 months ago (2012-01-28 01:06:19 UTC) #3
Lei Zhang
Try again. Also, CQ is your friend.
8 years, 11 months ago (2012-01-28 01:07:11 UTC) #4
not at google - send to devlin
On 2012/01/28 01:07:11, Lei Zhang wrote: > Try again. Also, CQ is your friend. (less ...
8 years, 11 months ago (2012-01-28 01:07:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9296002/5003
8 years, 11 months ago (2012-01-28 01:46:40 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-28 03:30:18 UTC) #7
Change committed as 119585

Powered by Google App Engine
This is Rietveld 408576698