Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: ppapi/tests/test_websocket.cc

Issue 9296001: WebSocket Pepper API: Remove binary type handling interfaces (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for review Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_websocket.cc
diff --git a/ppapi/tests/test_websocket.cc b/ppapi/tests/test_websocket.cc
index c0073eb24949590eeb6f9e6b319ed47099e7d202..15334d41e31e4ea6f25d8267886c4709bb131407 100644
--- a/ppapi/tests/test_websocket.cc
+++ b/ppapi/tests/test_websocket.cc
@@ -133,8 +133,6 @@ PP_Resource TestWebSocket::Connect(
protocols[0] = CreateVarString(protocol);
protocol_count = 1U;
}
- websocket_interface_->SetBinaryType(
- ws, PP_WEBSOCKETBINARYTYPE_ARRAYBUFFER_DEV);
*result = websocket_interface_->Connect(
ws, url_var, protocols, protocol_count,
static_cast<pp::CompletionCallback>(callback).pp_completion_callback());
@@ -197,10 +195,6 @@ std::string TestWebSocket::TestUninitializedPropertiesAccess() {
ASSERT_TRUE(AreEqualWithString(url, ""));
ReleaseVar(url);
- PP_WebSocketBinaryType_Dev binary_type =
- websocket_interface_->GetBinaryType(ws);
- ASSERT_EQ(PP_WEBSOCKETBINARYTYPE_BLOB_DEV, binary_type);
-
core_interface_->ReleaseResource(ws);
PASS();
@@ -572,7 +566,6 @@ std::string TestWebSocket::TestCcInterfaces() {
ASSERT_TRUE(AreEqualWithString(ws.GetURL().pp_var(), ""));
// Check communication interfaces (connect, send, receive, and close).
- ASSERT_TRUE(ws.SetBinaryType(PP_WEBSOCKETBINARYTYPE_ARRAYBUFFER_DEV));
TestCompletionCallback connect_callback(instance_->pp_instance());
int32_t result = ws.Connect(pp::Var(std::string(kCloseServerURL)), NULL, 0U,
connect_callback);
@@ -626,7 +619,6 @@ std::string TestWebSocket::TestCcInterfaces() {
ASSERT_TRUE(AreEqualWithString(ws.GetProtocol().pp_var(), ""));
ASSERT_EQ(PP_WEBSOCKETREADYSTATE_CLOSED_DEV, ws.GetReadyState());
ASSERT_TRUE(AreEqualWithString(ws.GetURL().pp_var(), kCloseServerURL));
- ASSERT_EQ(PP_WEBSOCKETBINARYTYPE_ARRAYBUFFER_DEV, ws.GetBinaryType());
PASS();
}

Powered by Google App Engine
This is Rietveld 408576698