Move DownloadQuery to chrome/

Move DownloadQuery to chrome/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120118

[benjhayden, 2012-01-31 16:18:23]

PTAL.
I'll email about alternate spellings in a separate thread.
Apologies for the mix-up.

[jam, 2012-01-31 17:30:08]

it's not clear yet to me that we want to expose this whole file to embedders. my
suggestion was to move both .h and .cc back out while we figure this out

[jam, 2012-01-31 17:32:42]

(I was planning on looking into this file more in depth in the afternoon, let me
look at it right now and then we can figure it out together over IM :) )

[jam, 2012-01-31 17:59:42]

(I looked at the code in more detail and chatted with Ben)

It seems that DownloadQuery is only used by extensions, and the only thing it
needs is the list of downloads, which are accessible from getters on
DownloadManager. Given that, I think we should keep DownloadQuery in chrome
beside the extensions code for now. If in the future we find that other
embedders or code in content needs it, we can consider moving it to content. But
given that it's only used by chrome, we should strive to keep the content API as
minimal as possible, and have it only provide the primitives that embedders can
build upon to add fancier searching etc that they need. This is the approach
used by the WebKit API as well. The fact that we haven't needed this class until
now further convinces me that it doesn't belong in the core code.

[benjhayden, 2012-01-31 19:05:06]

PTAL

[Randy Smith (Not in Mondays), 2012-01-31 19:37:36]

LGTM.

(Note for due process: This LGTM doesn't include content/public; that's a
substantive enough change that it needs John's LGTM.)

[benjhayden, 2012-01-31 20:53:38]

check_deps is complaining that
chrome/browser/download/download_query_unittest.cc shouldn't include
content/browser/download/mock_download_item.h
Should I copy it to chrome/browser/download?

[jam, 2012-01-31 21:12:34]

Sorry for delay, just got back to my desk. will review now.

On 2012/01/31 20:53:38, b s h wrote:
> check_deps is complaining that
> chrome/browser/download/download_query_unittest.cc shouldn't include
> content/browser/download/mock_download_item.h
> Should I copy it to chrome/browser/download?

we've been trying to move mock objects, especially those used by chrome, to
content/test.

[jam, 2012-01-31 21:13:43]

lgtm, thanks

[commit-bot: I haz the power, 2012-02-01 20:11:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/9293036/20001

[commit-bot: I haz the power, 2012-02-01 22:35:02]

Change committed as 120118