Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_stream_parser.h

Issue 9293029: net: Introduce SeekableIOBuffer and clean up HttpStreamParser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and update comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/io_buffer.h ('K') | « net/base/io_buffer.cc ('k') | net/http/http_stream_parser.cc » ('j') | net/http/http_stream_parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_parser.h
diff --git a/net/http/http_stream_parser.h b/net/http/http_stream_parser.h
index 861fbe9402956e1e22b6f0468b0947a6f70b4ea0..559f9e6df926339c1f04ad90c729ec333dbd9f79 100644
--- a/net/http/http_stream_parser.h
+++ b/net/http/http_stream_parser.h
@@ -20,6 +20,7 @@ namespace net {
class ClientSocketHandle;
class DrainableIOBuffer;
+class SeekableIOBuffer;
wtc 2012/02/02 20:22:57 Nit: list in alphabetical order.
satorux1 2012/02/02 22:02:27 Done.
class GrowableIOBuffer;
struct HttpRequestInfo;
class HttpRequestHeaders;
@@ -223,9 +224,7 @@ class NET_EXPORT_PRIVATE HttpStreamParser : public ChunkCallback {
// Stores an encoded chunk for chunked uploads.
// Note: This should perhaps be improved to not create copies of the data.
- scoped_refptr<IOBufferWithSize> raw_chunk_buf_;
- // Wraps raw_chunk_buf_ to read the remaining data progressively.
- scoped_refptr<DrainableIOBuffer> chunk_buf_;
+ scoped_refptr<SeekableIOBuffer> chunk_buf_;
size_t chunk_length_without_encoding_;
bool sent_last_chunk_;
« net/base/io_buffer.h ('K') | « net/base/io_buffer.cc ('k') | net/http/http_stream_parser.cc » ('j') | net/http/http_stream_parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698