Issue 9293011: History: Fix visual alignment of favicon and entry text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9293011: History: Fix visual alignment of favicon and entry text. (Closed)

Created:
8 years, 10 months ago by Patrick Dubroy

Modified:
8 years, 10 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, Patrick Dubroy, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

History: Fix visual alignment of favicon and entry text. - Increase line height by 1px so favicon can be visually centered. - Ensure entry text cap height is centered on the favicon. - Make checkboxes and drop-down buttons square. BUG=111941 TEST=Check visual alignment of items on chrome://history. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120049

Patch Set 1 #

Patch Set 2 : New version that doesn't make Linux look worse. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
	M	chrome/browser/resources/history.css	View	1	4 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/9293011/3

8 years, 10 months ago (2012-02-01 07:57:03 UTC) #3

Change committed as 120049

Expand Messages | Collapse Messages