Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9293008: Move click-to-play out of chrome://flags. (Closed)

Created:
8 years, 10 months ago by Bernhard Bauer
Modified:
8 years, 10 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, arv (Not doing code reviews), dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Move click-to-play out of chrome://flags. This makes the click-to-play feature available in content settings without having to enable it in chrome://flags. BUG=62084 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119773

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -70 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/content_settings_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/content_settings_utils.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/content_settings_exceptions_area.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Bernhard Bauer
Please review. Evan: WebUI options Peter: chrome/browser/ui Markus: content_settings and rest Thanks!
8 years, 10 months ago (2012-01-30 18:43:11 UTC) #1
laforge
This is a high priority from the leads/Linus, please prioritize these reviews accordingly. On 2012/01/30 ...
8 years, 10 months ago (2012-01-30 20:15:46 UTC) #2
Peter Kasting
LGTM for everything, although that might not give you sufficient OWNERS approval. http://codereview.chromium.org/9293008/diff/1/chrome/browser/content_settings/host_content_settings_map.cc File chrome/browser/content_settings/host_content_settings_map.cc ...
8 years, 10 months ago (2012-01-30 20:35:22 UTC) #3
Ben Goodger (Google)
LGTM as OWNERS for browser/ui. BTW, ui/content_settings could probably have its own OWNERS file.
8 years, 10 months ago (2012-01-30 20:48:15 UTC) #4
Bernhard Bauer
On 2012/01/30 20:48:15, Ben Goodger (Google) wrote: > LGTM as OWNERS for browser/ui. > > ...
8 years, 10 months ago (2012-01-30 20:56:47 UTC) #5
Evan Stade
webui and resources lgtm http://codereview.chromium.org/9293008/diff/23/chrome/browser/resources/options/content_settings_exceptions_area.js File chrome/browser/resources/options/content_settings_exceptions_area.js (right): http://codereview.chromium.org/9293008/diff/23/chrome/browser/resources/options/content_settings_exceptions_area.js#newcode364 chrome/browser/resources/options/content_settings_exceptions_area.js:364: this.enableAskOption = (this.contentType == 'plugins'); ...
8 years, 10 months ago (2012-01-30 21:26:56 UTC) #6
Bernhard Bauer
http://codereview.chromium.org/9293008/diff/23/chrome/browser/resources/options/content_settings_exceptions_area.js File chrome/browser/resources/options/content_settings_exceptions_area.js (right): http://codereview.chromium.org/9293008/diff/23/chrome/browser/resources/options/content_settings_exceptions_area.js#newcode364 chrome/browser/resources/options/content_settings_exceptions_area.js:364: this.enableAskOption = (this.contentType == 'plugins'); On 2012/01/30 21:26:56, Evan ...
8 years, 10 months ago (2012-01-30 21:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9293008/6003
8 years, 10 months ago (2012-01-30 21:32:51 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 00:08:51 UTC) #9 
Change committed as 119773

Powered by Google App Engine
This is Rietveld 408576698