Remove llvm bitcode reader localmod that dropped datalayout.

Remove llvm bitcode reader localmod that dropped datalayout.

As described in bug 2554, this enables a few more "opt" optimizations since "opt" relies on this for the datalayout ("opt" differs from "llc" in that it only uses the target triple for TargetLibraryInfo).

Alternatively, we could leave it out of the bitcode and feed the datalayout to opt through a commandline parameter, but we probably want to enforce some consistency w/ Clang -O options (which had already done things assuming the datalayout in the bitcode file), and the commandline option could go out of sync more quickly.

related to:
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2554

[(google.com) Derek Schuff, 2012-01-26 20:52:59]

lgtm

[jvoung - send to chromium..., 2012-02-01 00:58:04]

We haven't done a toolchain roll in a while so I was tried it out, but the
pnacl/test.sh test-arm-sbtc keeps failing.

Will be out tomorrow, but this might be the candidate for reverting.


On Thu, Jan 26, 2012 at 12:52 PM, <dschuff@google.com> wrote:

> lgtm
>
>
>
>
http://codereview.chromium.**org/9290056/<http://codereview.chromium.org/9290...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[robertm, 2012-02-01 17:25:59]

Pdox,

this maybe reason for the failed deps roll

Robert

On 2012/02/01 00:58:04, jvoung wrote:
> We haven't done a toolchain roll in a while so I was tried it out, but the
> pnacl/test.sh test-arm-sbtc keeps failing.
> 
> Will be out tomorrow, but this might be the candidate for reverting.
> 
> 
> On Thu, Jan 26, 2012 at 12:52 PM, <mailto:dschuff@google.com> wrote:
> 
> > lgtm
> >
> >
> >
> >
>
http://codereview.chromium.**org/9290056/%3Chttp://codereview.chromium.org/92...>
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to
mailto:native-client-reviews@googlegroups.com.
> To unsubscribe from this group, send email to
> mailto:native-client-reviews+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/native-client-reviews?hl=en.
>

[jvoung - send to chromium..., 2012-02-03 00:26:00]

Darn I thought I had tested this, but yeah this is definitely tickling the
arm sbtc the wrong way.
I did a gclient sync + toolchain DEPS to exactly this revision and the one
before to check (doesn't work vs works)...
In other news, the toolchain bot does not run any test arm sbtc tests, but
I guess they take a long time.


On Wed, Feb 1, 2012 at 9:25 AM, <robertm@google.com> wrote:

> Pdox,
>
> this maybe reason for the failed deps roll
>
> Robert
>
>
> On 2012/02/01 00:58:04, jvoung wrote:
>
>> We haven't done a toolchain roll in a while so I was tried it out, but the
>> pnacl/test.sh test-arm-sbtc keeps failing.
>>
>
>  Will be out tomorrow, but this might be the candidate for reverting.
>>
>
>
>  On Thu, Jan 26, 2012 at 12:52 PM, <mailto:dschuff@google.com> wrote:
>>
>
>  > lgtm
>> >
>> >
>> >
>> >
>>
>
> http://codereview.chromium.****org/9290056/%3Chttp://coderevi**
> ew.chromium.org/9290056/ <http://codereview.chromium.org/9290056/>>
>
>> >
>>
>
>  --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To post to this group, send email to
>>
>
mailto:native-client-reviews@**googlegroups.com<native-client-reviews@googlegroups.com>
> .
>
>> To unsubscribe from this group, send email to
>>
mailto:native-client-reviews+**unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups.com>
>> .
>> For more options, visit this group at
>>
http://groups.google.com/**group/native-client-reviews?**hl=en<http://groups....
>> .
>>
>
>
>
>
>
http://codereview.chromium.**org/9290056/<http://codereview.chromium.org/9290...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.