Adding a scoped_nsprotocol

Adding a scoped_nsprotocol

This allow to easily own protocol. The syntax is:
scoped_nsobject<id<MyProtocol> > object;

BUG= none
TEST= none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119419

[qsr, 2012-01-26 11:12:54]

There might be something obvious I'm missing, but I'm unable today to have an
easy ownership for object that are defined by protocols. This solves this issue.
There is 2 obvious downside, but none of them seem that much of a problem:

You can write scoped_nsprotocol<FOO*> instead of scoped_nsobject<FOO> but that
just sounds stupid and can be catch at review.

 You can use the preceding syntax to do that for NSAutoReleasePool, but same
argument as before, and moreover, you can already do that today with
scoped_nsobject<id>

 PS: Sorry for the dup, opened the first one with the wrong account.

[Mark Mentovai, 2012-01-26 14:21:15]

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:82: // Free functions
Do these for scoped_nsprotocol too?

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:163: // Equivalent of scoped_nsobject for a
id<protocol>.
This is just scoped_nsobject without the helpful *s? That’s worth a comment.

[qsr, 2012-01-26 14:34:49]

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:82: // Free functions
On 2012/01/26 14:21:15, Mark Mentovai wrote:
> Do these for scoped_nsprotocol too?

Done.

http://codereview.chromium.org/9290046/diff/1001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:163: // Equivalent of scoped_nsobject for a
id<protocol>.
On 2012/01/26 14:21:15, Mark Mentovai wrote:
> This is just scoped_nsobject without the helpful *s? That’s worth a comment.

Done.

[Mark Mentovai, 2012-01-26 15:12:20]

http://codereview.chromium.org/9290046/diff/3001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

http://codereview.chromium.org/9290046/diff/3001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:217: bool operator==(C* p1, const
scoped_nsprotocol<C>& p2) {
Is the * correct?

Same on line 222.

[qsr (NOT THE RIGHT qsr), 2012-01-26 15:24:56]

http://codereview.chromium.org/9290046/diff/3001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

http://codereview.chromium.org/9290046/diff/3001/base/memory/scoped_nsobject....
base/memory/scoped_nsobject.h:217: bool operator==(C* p1, const
scoped_nsprotocol<C>& p2) {
 Done. Thanks.

[Mark Mentovai, 2012-01-26 15:39:37]

LGTM

[commit-bot: I haz the power, 2012-01-27 07:35:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/9290046/4002

[commit-bot: I haz the power, 2012-01-27 09:07:20]

Change committed as 119419