chrome/common/extensions/docs/examples/api/topsites/magic8ball.zip - Issue 9289057: Changing manifest to v2 extension samples

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/examples/api/topsites/magic8ball.zip

Issue 9289057: Changing manifest to v2 extension samples (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Adding zip files after rebasing with master Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/api/tabs/pin/manifest.json ('k') | chrome/common/extensions/docs/examples/api/topsites/magic8ball/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 PKªT?ô¬magic8ball/manifest.json{	1 PKªT?ô¬magic8ball/manifest.json{

2 "name": "NTP prototyping extension",	2 "name": "NTP prototyping extension",

3 "version": "1.0",	3 "version": "1.0",

4 "description": "extension to prototype new NTP designs",	4 "description": "extension to prototype new NTP designs",

5 "chrome_url_overrides" : {	5 "chrome_url_overrides" : {

6 "newtab": "newTab.html"	6 "newtab": "newTab.html"

7 },	7 },

8 "permissions": [	8 "permissions": [

9 "experimental",	9 "experimental",

10 "chrome://favicon/",	10 "chrome://favicon/",

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	87

88 var span = eightBallWindow.querySelector('span');	88 var span = eightBallWindow.querySelector('span');

89 span.textContent = data[rand].title;	89 span.textContent = data[rand].title;

90 span.style.backgroundImage = 'url(chrome://favicon/' + data[rand].url + ')';	90 span.style.backgroundImage = 'url(chrome://favicon/' + data[rand].url + ')';

91 }	91 }

92	92

93 window.onload = function() {	93 window.onload = function() {

94 chrome.experimental.topSites.get(thumbnailsGotten);	94 chrome.experimental.topSites.get(thumbnailsGotten);

95 }	95 }

96 PKªT?ô¬( magic8ball/manifest.jsonfcaa8182e4 0d3ad7a4ed836e42d533cade008716PKT?o´´8rr Hmagi c8ball/newTab.cssPKT?Ê,êåå ímagic8ball/newTab .htmlPKT?F[¨õõ magic8ball/newTab.jsPK 7-	96 PKªT?ô¬( magic8ball/manifest.jsonfcaa8182e4 0d3ad7a4ed836e42d533cade008716PKT?o´´8rr Hmagi c8ball/newTab.cssPKT?Ê,êåå ímagic8ball/newTab .htmlPKT?F[¨õõ magic8ball/newTab.jsPK 7-

OLD	NEW