Adding GpuMemoryManager to track GpuCommandBufferStub visibility and last_used_time and dictate mem…

content/common/gpu/gpu_channel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include "content/common/gpu/gpu_channel.h"
 
@@ skipping 193 matching lines @@
       software_));
   router_.AddRoute(*route_id, stub.get());
   stubs_.AddWithID(stub.release(), *route_id);
 #endif  // ENABLE_GPU
 }
 
 GpuCommandBufferStub* GpuChannel::LookupCommandBuffer(int32 route_id) {
   return stubs_.Lookup(route_id);
 }
 
+std::vector<GpuCommandBufferStub*> GpuChannel::GetCommandBuffers() {

[nduca, 2012/01/27 10:10:13]

Better to return the stubmap and let the code upstream do the iteration. You're
doing a copy here. :(

[Ken Russell (switch to Gerrit), 2012/01/27 19:21:24]

Returning the StubMap would expose more implementation details of the
GpuChannel. If this isn't performance critical code then returning a vector
seems fine to me.

[mmocny, 2012/01/27 19:51:33]

I had it that way at first, but this was cleaner.  The map is a nasty data
structure for external clients to know about..  And can't we rely on return
value optimization here?
Its an easy change so I won't argue too much.

On 2012/01/27 10:10:13, nduca wrote:

+  std::vector<GpuCommandBufferStub*> ret;
+  for (StubMap::Iterator<GpuCommandBufferStub> it(&stubs_);
+      !it.IsAtEnd(); it.Advance()) {
+    ret.push_back(it.GetCurrentValue());
+  }
+  return ret;
+}
+
 bool GpuChannel::OnControlMessageReceived(const IPC::Message& msg) {
   // Always use IPC_MESSAGE_HANDLER_DELAY_REPLY for synchronous message handlers
   // here. This is so the reply can be delayed if the scheduler is unscheduled.
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(GpuChannel, msg)
     IPC_MESSAGE_HANDLER(GpuChannelMsg_Initialize, OnInitialize)
     IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuChannelMsg_CreateOffscreenCommandBuffer,
                                     OnCreateOffscreenCommandBuffer)
     IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuChannelMsg_DestroyCommandBuffer,
                                     OnDestroyCommandBuffer)
@@ skipping 208 matching lines @@
 
 #if defined(OS_POSIX)
 int GpuChannel::TakeRendererFileDescriptor() {
   if (!channel_.get()) {
     NOTREACHED();
     return -1;
   }
   return channel_->TakeClientFileDescriptor();
 }
 #endif  // defined(OS_POSIX)