Remove reinterpret_cast on JSONValueConverter

Remove reinterpret_cast on JSONValueConverter


BUG=None
TEST='JSONValueConverterTest.*'


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119393

[tzik, 2012-01-26 04:25:23]

Hi, mukai-san.
As we talked in the tech-talk, how about removing reinterpret_cast like this?

[Jun Mukai, 2012-01-26 06:43:44]

LGTM.  Thanks for doing this.  I don't remember why I used reinterpret_cast, but
it's much better if we can omit it.

Please receive review from Evan, or someone who owns this.

[Evan Martin, 2012-01-26 16:03:55]

http://codereview.chromium.org/9289040/diff/2003/base/json/json_value_convert...
File base/json/json_value_converter.h (right):

http://codereview.chromium.org/9289040/diff/2003/base/json/json_value_convert...
base/json/json_value_converter.h:12: #include "base/base_export.h"
It appears BASE_EXPORT is no longer used in this file.

Does this file not export any API?  Does your change not break the components
build?

[tzik, 2012-01-27 02:04:10]

http://codereview.chromium.org/9289040/diff/2003/base/json/json_value_convert...
File base/json/json_value_converter.h (right):

http://codereview.chromium.org/9289040/diff/2003/base/json/json_value_convert...
base/json/json_value_converter.h:12: #include "base/base_export.h"
On 2012/01/26 16:03:55, Evan Martin wrote:
> It appears BASE_EXPORT is no longer used in this file.
Done.

> 
> Does this file not export any API?  Does your change not break the components
> build?

No, this change will not export any symbol to libbase.a.
Since all classes in this file are template class, symbols are resolved in
compile stage, not in link stage.

[Evan Martin, 2012-01-27 02:47:13]

LGTM

[commit-bot: I haz the power, 2012-01-27 03:33:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/9289040/6001

[commit-bot: I haz the power, 2012-01-27 07:12:24]

Change committed as 119393