Added Net logging to FileStream.

net/base/file_stream.h

Index: net/base/file_stream.h
diff --git a/net/base/file_stream.h b/net/base/file_stream.h
index f2a8f7f4f94701027ed5a2a08b822dec83491922..142f806ca89cb689431fb7883ab7ff38dd73f7cf 100644
--- a/net/base/file_stream.h
+++ b/net/base/file_stream.h
@@ -15,6 +15,7 @@
 #include "base/platform_file.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
+#include "net/base/net_log.h"
 
 class FilePath;
 
@@ -32,6 +33,9 @@ class NET_EXPORT FileStream {
  public:
   FileStream();
 
+  // Create a new BoundNetLog and attach it to the stream.

[Randy Smith (Not in Mondays), 2012/01/30 21:27:41]

The primary thing a constructor does is construct an object of the type, so I'd
phrase this as "Construct a file stream with a BoundNetLog attached to the
passed NetLog."

[ahendrickson, 2012/01/30 22:30:53]

Done.

+  FileStream(net::NetLog* log);
+
   // Construct a FileStream with an existing file handle and opening flags.
   // |file| is valid file handle.
   // |flags| is a bitfield of base::PlatformFileFlags when the file handle was
@@ -136,6 +140,9 @@ class NET_EXPORT FileStream {
   // Turns on UMA error statistics gathering.
   void EnableErrorStatistics();
 
+  // Sets the source reference for net-internals logging.

[Randy Smith (Not in Mondays), 2012/01/30 21:27:41]

If this has restrictions with regard to how the FileStream was constructed, they
should be spelled out in the comment.  (I.e. if this is only valid to call if
the FileStream was constructed with a net::NetLog*, or behaves differently in
that case, it should be spelled out in the comment).

[ahendrickson, 2012/01/30 22:30:53]

The only difference is that if |net_log_| is invalid, nothing happens.
Commented.

+  void SetBoundNetLogSource(const net::BoundNetLog& log);
+
  private:
   class AsyncContext;
   friend class AsyncContext;
@@ -149,6 +156,7 @@ class NET_EXPORT FileStream {
   int open_flags_;
   bool auto_closed_;
   bool record_uma_;
+  net::BoundNetLog net_log_;

[Randy Smith (Not in Mondays), 2012/01/30 21:27:41]

I'm uncomfortable calling a BoundNetLog a net_log_, given that we've got NetLogs
wandering around as well.  I'd suggest you regularize naming so that you always
use the same string (or a variation of it) for BoundNetLogs and NetLogs. 
(Suggestion, not requirement.)

[ahendrickson, 2012/01/30 22:30:53]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(FileStream);
 };