Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: net/base/net_log_event_type_list.h

Issue 9288084: Added Net logging to FileStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplified SetBoundNetLogSource() again. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 44f6f22bbf26a48445921100295fd301d65fb8cc..f1977b76596588552ec3504e5b5683a5b5c5026e 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -1407,3 +1407,42 @@ EVENT_TYPE(HTTP_PIPELINED_CONNECTION_RECEIVED_HEADERS)
// "must_close": <True if the pipeline must shut down>,
// }
EVENT_TYPE(HTTP_PIPELINED_CONNECTION_STREAM_CLOSED)
+
+// ------------------------------------------------------------------------
+// FileStream events.
+// ------------------------------------------------------------------------
+
+// This event lasts the lifetime of a file stream.
+EVENT_TYPE(FILE_STREAM_ALIVE)
+
+// This event is created when a file stream is associated with a NetLog source.
+// It indicates what file stream event source is used.
+// {
+// "source_dependency": <Source id of the file stream>,
+// }
+EVENT_TYPE(FILE_STREAM_SOURCE)
+
+// This event is created when a file stream is associated with a NetLog source.
+// It indicates what event source owns the file stream source.
+// {
+// "source_dependency": <Source id of the owner of the file stream>,
+// }
+EVENT_TYPE(FILE_STREAM_BOUND_TO_OWNER)
+
+// This event is created when a file stream is opened.
mmenke 2012/02/01 16:25:52 nit: Mention the end event. Maybe something alon
ahendrickson 2012/02/01 18:38:32 Done.
+// {
+// "file_name".
+// }
+EVENT_TYPE(FILE_STREAM_OPEN)
+
+// This event is created when a file stream is closed.
+EVENT_TYPE(FILE_STREAM_CLOSE)
+
+// This event is created when a file stream operation has an error.
+// {
+// "operation": open, write, close, etc.
+// "os_error": OS-dependent error code.
+// "net_error": net::Error code.
+// "net_error_name": Name of net::Error code.
mmenke 2012/02/01 16:25:52 nit: Not needed, as per other comment.
ahendrickson 2012/02/01 18:38:32 Done.
+// }
+EVENT_TYPE(FILE_STREAM_ERROR)

Powered by Google App Engine
This is Rietveld 408576698