Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: net/base/net_log_event_type_list.h

Issue 9288084: Added Net logging to FileStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renamed BoundNetLog variables. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 44f6f22bbf26a48445921100295fd301d65fb8cc..6dc12d7bc3bfb3fe232f2fdf76ac798e11ce3746 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -1407,3 +1407,40 @@ EVENT_TYPE(HTTP_PIPELINED_CONNECTION_RECEIVED_HEADERS)
// "must_close": <True if the pipeline must shut down>,
// }
EVENT_TYPE(HTTP_PIPELINED_CONNECTION_STREAM_CLOSED)
+
+// ------------------------------------------------------------------------
+// FileStream events.
+// ------------------------------------------------------------------------
+
+// This event is created when a file stream is associated with a NetLog source.
+// It indicates what file stream event source is used.
+// {
+// "source_dependency": <Source id of the file stream>,
+// }
+EVENT_TYPE(FILE_STREAM_SOURCE)
+
+// This event is created when a file stream is associated with a NetLog source.
+// It indicates what event source owns the file stream source.
+// {
+// "source_dependency": <Source id of the owner of the file stream>,
+// }
+EVENT_TYPE(FILE_STREAM_BOUND_TO_OWNER)
+
+// This event lasts the lifetime of a file stream.
+EVENT_TYPE(FILE_STREAM_ALIVE)
mmenke 2012/01/31 18:28:43 nit: Suggest putting these events in rough order
ahendrickson 2012/01/31 20:12:41 Done.
+
+// This event is created when a file stream is opened.
+// {
+// "file_name".
+// }
+EVENT_TYPE(FILE_STREAM_OPEN)
+
+// This event is created when a file stream is closed.
+EVENT_TYPE(FILE_STREAM_CLOSE)
mmenke 2012/01/31 18:28:43 I'd suggest you use begin/end events for OPEN rath
ahendrickson 2012/01/31 20:12:41 I do use begin/end events for OPEN. However, I wa
+
+// This event is created when a file stream operation has an error.
+// {
+// "operation": open, write, close, etc.
+// "sys_error": OS-dependent error code.
mmenke 2012/01/30 22:38:39 nit: os_error (And add net_error)
ahendrickson 2012/01/31 20:12:41 Done.
+// }
+EVENT_TYPE(FILE_STREAM_ERROR)

Powered by Google App Engine
This is Rietveld 408576698