Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: net/base/file_stream.h

Issue 9288084: Added Net logging to FileStream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed typo in posix version of file stream. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/file_stream.h
diff --git a/net/base/file_stream.h b/net/base/file_stream.h
index f2a8f7f4f94701027ed5a2a08b822dec83491922..142f806ca89cb689431fb7883ab7ff38dd73f7cf 100644
--- a/net/base/file_stream.h
+++ b/net/base/file_stream.h
@@ -15,6 +15,7 @@
#include "base/platform_file.h"
#include "net/base/completion_callback.h"
#include "net/base/net_export.h"
+#include "net/base/net_log.h"
Randy Smith (Not in Mondays) 2012/01/30 23:29:13 Why can't this just be forward references?
ahendrickson 2012/01/31 20:12:40 Because we have a BoundNetLog member variable.
class FilePath;
@@ -32,6 +33,9 @@ class NET_EXPORT FileStream {
public:
FileStream();
+ // Create a new BoundNetLog and attach it to the stream.
rvargas (doing something else) 2012/01/30 23:11:38 nit: "Constructs a FileStream..." or similar
ahendrickson 2012/01/31 20:12:40 Done.
+ FileStream(net::NetLog* log);
rvargas (doing something else) 2012/01/30 23:11:38 Is the idea to remove the default constructor once
ahendrickson 2012/01/31 20:12:40 Removed the default constructor, based on this and
+
// Construct a FileStream with an existing file handle and opening flags.
// |file| is valid file handle.
// |flags| is a bitfield of base::PlatformFileFlags when the file handle was
@@ -136,6 +140,9 @@ class NET_EXPORT FileStream {
// Turns on UMA error statistics gathering.
void EnableErrorStatistics();
+ // Sets the source reference for net-internals logging.
+ void SetBoundNetLogSource(const net::BoundNetLog& log);
+
private:
class AsyncContext;
friend class AsyncContext;
@@ -149,6 +156,7 @@ class NET_EXPORT FileStream {
int open_flags_;
bool auto_closed_;
bool record_uma_;
+ net::BoundNetLog net_log_;
DISALLOW_COPY_AND_ASSIGN(FileStream);
};

Powered by Google App Engine
This is Rietveld 408576698