build/common.gypi: split out filename exclude rules

build/common.gypi: split out filename exclude rules

Here's a step towards making this enormous file a little more tractable.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119372

[Evan Martin, 2012-01-26 21:53:28]

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gypi
File build/filename_rules.gypi (right):

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gy...
build/filename_rules.gypi:23: # In case a file is not needed, it is going to be
excluded later on.
I disagree with this comment, but I'm attempting to not change anything from the
original file.

[Nico, 2012-01-26 22:05:50]

LGTM

I checked that no blocks got dropped. I didn't check the regexen.

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gypi
File build/filename_rules.gypi (right):

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gy...
build/filename_rules.gypi:44: ['exclude', '_xdg(_unittest)?\\.(h|cc)$'],
Can this be merged into the other OS!=linux && !=openbsd && != freebsd blcok?

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gy...
build/filename_rules.gypi:51: ['exclude',
'_(chromeos|x|x11)(_unittest)?\\.(h|cc)$'],
use_x11=1 excludes chromeos_unittests? huh.

[Evan Martin, 2012-01-26 22:09:39]

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gypi
File build/filename_rules.gypi (right):

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gy...
build/filename_rules.gypi:44: ['exclude', '_xdg(_unittest)?\\.(h|cc)$'],
On 2012/01/26 22:05:50, Nico wrote:
> Can this be merged into the other OS!=linux && !=openbsd && != freebsd blcok?

I put a TODO on the other block about how it should be linux-only.  This block
is conceptually "free desktop-y OSes" (that's what xdg stands for)

https://chromiumcodereview.appspot.com/9288078/diff/1/build/filename_rules.gy...
build/filename_rules.gypi:51: ['exclude',
'_(chromeos|x|x11)(_unittest)?\\.(h|cc)$'],
On 2012/01/26 22:05:50, Nico wrote:
> use_x11=1 excludes chromeos_unittests? huh.

Hahah, no idea why.

[commit-bot: I haz the power, 2012-01-27 00:13:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan@chromium.org/9288078/1004

[commit-bot: I haz the power, 2012-01-27 02:21:27]

Try job failure for 9288078-1004 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-01-27 02:34:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan@chromium.org/9288078/1004

[commit-bot: I haz the power, 2012-01-27 04:55:17]

Change committed as 119372