chrome/test/webdriver/commands/chrome_commands.cc - Issue 9288051: Implement the webdriver window sizing commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/chrome_commands.cc

Issue 9288051: Implement the webdriver window sizing commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/chrome_commands.cc

diff --git a/chrome/test/webdriver/commands/chrome_commands.cc b/chrome/test/webdriver/commands/chrome_commands.cc

index dca46ae39feaf64b96327fa700293f01f8802749..27a84f55f15022ab43db99dafb95d405eee6c0d3 100644

--- a/chrome/test/webdriver/commands/chrome_commands.cc

+++ b/chrome/test/webdriver/commands/chrome_commands.cc

@@ -246,7 +246,7 @@ void ViewsCommand::ExecuteGet(Response* const response) {

for (size_t i = 0; i < views.size(); ++i) {

DictionaryValue* dict = new DictionaryValue();

AutomationId id = views[i].view_id.GetId();

- dict->SetString("handle", JsonStringify(id.ToValue()));

+ dict->SetString("handle", WebViewIdToString(WebViewId::ForView(id)));

dict->SetInteger("type", id.type());

if (!views[i].extension_id.empty())

dict->SetString("extension_id", views[i].extension_id);