Implement the webdriver window sizing commands.

Implement the webdriver window sizing commands.
BUG=107630
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119555

[dennis_jeffrey, 2012-01-27 16:23:28]

LGTM

A handful of nits.

http://codereview.chromium.org/9288051/diff/7002/chrome/browser/automation/te...
File chrome/browser/automation/testing_automation_provider.h (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/browser/automation/te...
chrome/browser/automation/testing_automation_provider.h:1098: // Sets the
specified view bounds.
Is it clear what "view" we're talking about here?  Should we add an adjective to
the function name to clarify which view it is?

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:924: 
insert another blank line here

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:985: 
insert another blank line here

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:1043: 
insert another blank line here

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:724: &auto_error))
nit: fit as many params on a line as you can, rather than having 1 per line (to
make it consistent with the rest of this file).

[commit-bot: I haz the power, 2012-01-27 19:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/9288051/10002

[commit-bot: I haz the power, 2012-01-27 21:28:06]

Try job failure for 9288051-10002 (retry) on win_rel for step
"content_unittests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-27 21:52:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/9288051/10002

[kkania, 2012-01-27 22:48:31]

http://codereview.chromium.org/9288051/diff/7002/chrome/browser/automation/te...
File chrome/browser/automation/testing_automation_provider.h (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/browser/automation/te...
chrome/browser/automation/testing_automation_provider.h:1098: // Sets the
specified view bounds.
On 2012/01/27 16:23:29, dennis_jeffrey wrote:
> Is it clear what "view" we're talking about here?  Should we add an adjective
to
> the function name to clarify which view it is?

i suppose it would be more clear by adding web to it. Done.

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:924: 
On 2012/01/27 16:23:29, dennis_jeffrey wrote:
> insert another blank line here

Done.

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:985: 
On 2012/01/27 16:23:29, dennis_jeffrey wrote:
> insert another blank line here

Sorry. I think I keep on forgetting this. Done.

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/test/c...
chrome/test/webdriver/test/chromedriver_tests.py:1043: 
On 2012/01/27 16:23:29, dennis_jeffrey wrote:
> insert another blank line here

Done.

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/9288051/diff/7002/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:724: &auto_error))
On 2012/01/27 16:23:29, dennis_jeffrey wrote:
> nit: fit as many params on a line as you can, rather than having 1 per line
(to
> make it consistent with the rest of this file).

Done.

[commit-bot: I haz the power, 2012-01-28 02:12:43]

Change committed as 119555