Log client IP addresses to syslog in Me2Me host.

Log client IP addresses to syslog in Me2Me host.

Follows on from http://codereview.chromium.org/9288010/ and
http://codereview.chromium.org/9271026/


BUG=109682
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119326

[Lambros, 2012-01-26 00:03:21]

The actual logging is in host_event_logger.cc.  Everything else is mostly
boilerplate.

[Sergey Ulanov, 2012-01-26 00:48:56]

lgtm

http://codereview.chromium.org/9288040/diff/1/remoting/host/chromoting_host.cc
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/chromoting_host.c...
remoting/host/chromoting_host.cc:233: // Notify observers.
this comment is redundant

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger.cc
File remoting/host/host_event_logger.cc (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger...
remoting/host/host_event_logger.cc:47: std::string username = jid.substr(0,
jid.find('/'));
I don't think we should strip resourceId from the jid. Why not log the full jid?

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger...
remoting/host/host_event_logger.cc:52: std::string username = jid.substr(0,
jid.find('/'));
same here

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_status_obser...
File remoting/host/host_status_observer.h (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_status_obser...
remoting/host/host_status_observer.h:37: const net::IPEndPoint& end_point) = 0;
It may be better to provide default empty handler here instead of making it pure
virtual, so that only implementations that are interested in this notification
need to override this method.

[Wez, 2012-01-26 19:17:17]

lgtm

[Lambros, 2012-01-26 19:40:14]

http://codereview.chromium.org/9288040/diff/1/remoting/host/chromoting_host.cc
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/chromoting_host.c...
remoting/host/chromoting_host.cc:233: // Notify observers.
On 2012/01/26 00:48:56, sergeyu wrote:
> this comment is redundant

Done (it was a copy-paste).

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger.cc
File remoting/host/host_event_logger.cc (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger...
remoting/host/host_event_logger.cc:47: std::string username = jid.substr(0,
jid.find('/'));
On 2012/01/26 00:48:56, sergeyu wrote:
> I don't think we should strip resourceId from the jid. Why not log the full
jid?

Done.

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_event_logger...
remoting/host/host_event_logger.cc:52: std::string username = jid.substr(0,
jid.find('/'));
On 2012/01/26 00:48:56, sergeyu wrote:
> same here

Done.

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_status_obser...
File remoting/host/host_status_observer.h (right):

http://codereview.chromium.org/9288040/diff/1/remoting/host/host_status_obser...
remoting/host/host_status_observer.h:37: const net::IPEndPoint& end_point) = 0;
On 2012/01/26 00:48:56, sergeyu wrote:
> It may be better to provide default empty handler here instead of making it
pure
> virtual, so that only implementations that are interested in this notification
> need to override this method.

Done.

[commit-bot: I haz the power, 2012-01-26 19:40:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9288040/1011

[commit-bot: I haz the power, 2012-01-26 20:21:23]

Try job failure for 9288040-1011 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-01-26 20:48:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9288040/1011

[commit-bot: I haz the power, 2012-01-27 01:51:47]

Change committed as 119326