Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 9288016: [uber page] Split out part of headers CL to make review easier. (Closed)

Created:
8 years, 11 months ago by Dan Beam
Modified:
8 years, 11 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Split out part of headers CL to make review easier. This CL simply wraps all <h1> tags into the sexier (and newer) version of <hgroup> - the <header> tag. R=tbreisacher@chromium.org,csilv@chromium.org BUG=110658 TEST=Nothing about uber page looks different (yet). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119130

Patch Set 1 #

Total comments: 2

Patch Set 2 : removing accidental CL leakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M chrome/browser/resources/options2/advanced_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/autofill_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/certificate_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/change_picture_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_detail.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/language_chewing_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/language_hangul_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/language_mozc_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/language_pinyin_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/content_settings_exceptions_area.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/cookies_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/font_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/handler_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/intents_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/language_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/password_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/search_engine_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/search_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Dan Beam
8 years, 11 months ago (2012-01-25 06:35:20 UTC) #1
Dan Beam
tbresaicher: This is a part of my uber page headers & subpages CL. I'm wrapping ...
8 years, 11 months ago (2012-01-25 06:48:56 UTC) #2
Dan Beam
On 2012/01/25 06:48:56, Dan Beam wrote: > tbresaicher: tbreisacher as well
8 years, 11 months ago (2012-01-25 07:18:31 UTC) #3
Dan Beam
+csilv for OWNERS check / review / possible justification of why the heck this CL ...
8 years, 11 months ago (2012-01-25 07:34:20 UTC) #4
Tyler Breisacher (Chromium)
https://chromiumcodereview.appspot.com/9288016/diff/1/chrome/browser/resources/options2/options.html File chrome/browser/resources/options2/options.html (right): https://chromiumcodereview.appspot.com/9288016/diff/1/chrome/browser/resources/options2/options.html#newcode113 chrome/browser/resources/options2/options.html:113: <div id="subpage-backdrop" class="overlay" hidden></div> Was this intended to be ...
8 years, 11 months ago (2012-01-25 07:41:00 UTC) #5
Dan Beam
https://chromiumcodereview.appspot.com/9288016/diff/1/chrome/browser/resources/options2/options.html File chrome/browser/resources/options2/options.html (right): https://chromiumcodereview.appspot.com/9288016/diff/1/chrome/browser/resources/options2/options.html#newcode113 chrome/browser/resources/options2/options.html:113: <div id="subpage-backdrop" class="overlay" hidden></div> On 2012/01/25 07:41:00, tbreisacher wrote: ...
8 years, 11 months ago (2012-01-25 07:44:47 UTC) #6
Tyler Breisacher (Chromium)
lgtm
8 years, 11 months ago (2012-01-25 07:48:30 UTC) #7
csilv
lgtm
8 years, 11 months ago (2012-01-25 17:04:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9288016/1026
8 years, 11 months ago (2012-01-25 20:47:59 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 22:17:36 UTC) #10
Change committed as 119130

Powered by Google App Engine
This is Rietveld 408576698