Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 9288012: Add StringToUint and StringToUint64 methods to base/string_number_conversions.h. (Closed)

Created:
8 years, 11 months ago by not at google - send to devlin
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin, Matt Perry
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org, Matt Perry
Visibility:
Public.

Description

Add StringToUint and StringToUint64 methods to base/string_number_conversions.h. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M base/string_number_conversions.h View 2 chunks +8 lines, -1 line 0 comments Download
M base/string_number_conversions.cc View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
8 years, 11 months ago (2012-01-25 03:14:31 UTC) #1
not at google - send to devlin
(need for other patch: https://chromiumcodereview.appspot.com/9284013)
8 years, 11 months ago (2012-01-25 03:15:12 UTC) #2
Matt Perry
Will is away on leave, let's try Evan.
8 years, 11 months ago (2012-01-25 21:18:11 UTC) #3
Evan Martin
LGTm On Wed, Jan 25, 2012 at 1:18 PM, <mpcomplete@chromium.org> wrote: > Will is away ...
8 years, 11 months ago (2012-01-25 22:08:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9288012/1
8 years, 11 months ago (2012-01-25 22:19:39 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-26 00:27:33 UTC) #6
Change committed as 119150

Powered by Google App Engine
This is Rietveld 408576698