Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 9288010: More plumbing for logging connection IP addresses (Closed)

Created:
8 years, 11 months ago by Lambros
Modified:
8 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

More plumbing for logging connection IP addresses Followup CL to http://codereview.chromium.org/9271026/ - this passes the RouteChange() notification from ConnectionToClient through the various layers to the ChromotingHost. BUG=109682 TEST=Compiles, unit-tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119137

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix nits #

Patch Set 3 : Fix Windows compile #

Patch Set 4 : Fix license headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M remoting/host/chromoting_host.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/host/client_session.h View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
M remoting/host/client_session.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M remoting/host/host_mock_objects.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M remoting/host/host_mock_objects.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/connection_to_client.h View 1 2 3 6 chunks +17 lines, -4 lines 0 comments Download
M remoting/protocol/connection_to_client.cc View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lambros
This is just plumbing. I'm not sure I've chosen good names for some of these ...
8 years, 11 months ago (2012-01-25 01:23:36 UTC) #1
Sergey Ulanov
LGTM when my nits are addressed. http://codereview.chromium.org/9288010/diff/1/remoting/host/chromoting_host.h File remoting/host/chromoting_host.h (right): http://codereview.chromium.org/9288010/diff/1/remoting/host/chromoting_host.h#newcode28 remoting/host/chromoting_host.h:28: class IpEndPoint; remove ...
8 years, 11 months ago (2012-01-25 01:56:48 UTC) #2
Lambros
http://codereview.chromium.org/9288010/diff/1/remoting/host/chromoting_host.h File remoting/host/chromoting_host.h (right): http://codereview.chromium.org/9288010/diff/1/remoting/host/chromoting_host.h#newcode28 remoting/host/chromoting_host.h:28: class IpEndPoint; On 2012/01/25 01:56:48, sergeyu wrote: > remove ...
8 years, 11 months ago (2012-01-25 19:27:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9288010/1012
8 years, 11 months ago (2012-01-25 19:27:26 UTC) #4
commit-bot: I haz the power
Try job failure for 9288010-1012 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-25 19:54:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9288010/4003
8 years, 11 months ago (2012-01-25 20:22:20 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 23:11:25 UTC) #7
Try job failure for 9288010-4003 (retry) on win_rel for step "base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698