Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 9288006: Minor changes as per Christians most-recent review of the docs. (Closed)

Created:
8 years, 11 months ago by jond
Modified:
8 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Minor changes as per Christians most-recent review of the docs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122337

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ppapi/cpp/audio.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
noelallen_use_chromium
LGTM I don't remember seeing this. Make sure you --send_mail when you upload, or just ...
8 years, 10 months ago (2012-02-11 00:09:40 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-15 17:07:37 UTC) #2
dmichael (off chromium)
http://codereview.chromium.org/9288006/diff/1011/ppapi/api/ppb_file_system.idl File ppapi/api/ppb_file_system.idl (right): http://codereview.chromium.org/9288006/diff/1011/ppapi/api/ppb_file_system.idl#newcode57 ppapi/api/ppb_file_system.idl:57: // be opened in it. Clarify what it means ...
8 years, 10 months ago (2012-02-15 17:53:50 UTC) #3
jond
http://codereview.chromium.org/9288006/diff/1011/ppapi/api/ppb_file_system.idl File ppapi/api/ppb_file_system.idl (right): http://codereview.chromium.org/9288006/diff/1011/ppapi/api/ppb_file_system.idl#newcode57 ppapi/api/ppb_file_system.idl:57: // be opened in it. Clarify what it means ...
8 years, 10 months ago (2012-02-15 22:33:53 UTC) #4
dmichael (off chromium)
lgtm
8 years, 10 months ago (2012-02-15 22:40:36 UTC) #5
dmichael (off chromium)
Oops, one more thing. Otherwise lgtm. http://codereview.chromium.org/9288006/diff/11001/ppapi/cpp/var.h File ppapi/cpp/var.h (right): http://codereview.chromium.org/9288006/diff/11001/ppapi/cpp/var.h#newcode72 ppapi/cpp/var.h:72: /// http://code.google.com/p/chromium/issues/detail?id=52105 This ...
8 years, 10 months ago (2012-02-15 22:42:25 UTC) #6
jond
http://codereview.chromium.org/9288006/diff/11001/ppapi/cpp/var.h File ppapi/cpp/var.h (right): http://codereview.chromium.org/9288006/diff/11001/ppapi/cpp/var.h#newcode72 ppapi/cpp/var.h:72: /// http://code.google.com/p/chromium/issues/detail?id=52105 On 2012/02/15 22:42:25, dmichael wrote: > This ...
8 years, 10 months ago (2012-02-16 18:10:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jond@google.com/9288006/15001
8 years, 10 months ago (2012-02-16 18:10:25 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 19:33:11 UTC) #9
Change committed as 122337

Powered by Google App Engine
This is Rietveld 408576698