Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 9286003: Remove AsyncSetOwnerUser() from cryptohome library (Closed)

Created:
8 years, 11 months ago by use bartfab instead
Modified:
8 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, pastarmovj, hashimoto
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove AsyncSetOwnerUser() from cryptohome library The fix for issue chromium-os:25464 will make AsyncSetOwnerUser() obsolete. This CL removes the method and any calls to it. BUG=chromium:111328 TEST=browser_test ExistingUserControllerTest.* CQ-DEPEND=I2c085b927fd5412edf02f9026cad5dd7fc608ccc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120688

Patch Set 1 : Restoring the CL that I just managed to delete... #

Patch Set 2 : Ready to go. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M chrome/browser/chromeos/cros/cryptohome_library.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/cryptohome_library.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_cryptohome_library.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/mock_cryptohome_library.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
use bartfab instead
8 years, 10 months ago (2012-01-30 14:42:07 UTC) #1
use bartfab instead
Hi Dave, could you have a look at this? The Chrome OS side has been ...
8 years, 10 months ago (2012-01-30 15:15:12 UTC) #2
Nikita (slow)
Denis Glotov is a better reviewer.
8 years, 10 months ago (2012-02-03 12:14:32 UTC) #3
Nikita (slow)
as he added this call.
8 years, 10 months ago (2012-02-03 12:14:45 UTC) #4
use bartfab instead
I saw that Denis added the call but figured I should ask one of the ...
8 years, 10 months ago (2012-02-03 12:20:12 UTC) #5
glotov
LGTM. Just a question. How does cryptohomed know the owner now?
8 years, 10 months ago (2012-02-06 11:41:30 UTC) #6
use bartfab instead
Cryptohomed now uses libpolicy which extracts this information from the device's policy blob, see: http://crosbug.com/25464
8 years, 10 months ago (2012-02-06 11:43:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/11002
8 years, 10 months ago (2012-02-06 11:43:49 UTC) #8
commit-bot: I haz the power
Can't process patch for file chrome/browser/chromeos/login/existing_user_controller_browsertest.cc. File's status is None, patchset upload is incomplete.
8 years, 10 months ago (2012-02-06 11:43:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/9009
8 years, 10 months ago (2012-02-06 11:51:35 UTC) #10
commit-bot: I haz the power
Presubmit check for 9286003-9009 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-06 11:51:42 UTC) #11
use bartfab instead
Hi Satoru, could you review with your cros hat on?
8 years, 10 months ago (2012-02-06 11:53:26 UTC) #12
satorux1
LGTM. Removing code from 'cros' is awesome. :)
8 years, 10 months ago (2012-02-06 16:16:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/9009
8 years, 10 months ago (2012-02-06 16:21:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/9009
8 years, 10 months ago (2012-02-06 17:35:31 UTC) #15
commit-bot: I haz the power
Try job failure for 9286003-9009 (retry) on mac_rel for steps "browser_tests, ui_tests". It's a second ...
8 years, 10 months ago (2012-02-06 20:13:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/9009
8 years, 10 months ago (2012-02-06 20:25:21 UTC) #17
commit-bot: I haz the power
Try job failure for 9286003-9009 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 22:40:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9286003/9009
8 years, 10 months ago (2012-02-06 22:43:36 UTC) #19
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 02:06:27 UTC) #20
Change committed as 120688

Powered by Google App Engine
This is Rietveld 408576698