Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 9284010: minimal cleanup of ssl error page (Closed)

Created:
8 years, 11 months ago by Evan Stade
Modified:
8 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

minimal cleanup of ssl error page BUG=107052 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119019

Patch Set 1 #

Patch Set 2 : fixed background jibba jabba #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -80 lines) Patch
M chrome/browser/resources/ssl_roadblock.html View 1 2 chunks +64 lines, -80 lines 4 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
8 years, 11 months ago (2012-01-24 05:14:01 UTC) #1
Dan Beam
http://codereview.chromium.org/9284010/diff/2001/chrome/browser/resources/ssl_roadblock.html File chrome/browser/resources/ssl_roadblock.html (right): http://codereview.chromium.org/9284010/diff/2001/chrome/browser/resources/ssl_roadblock.html#newcode43 chrome/browser/resources/ssl_roadblock.html:43: -webkit-transform: scaleX(-1); !>>>(^o^)<<<! http://codereview.chromium.org/9284010/diff/2001/chrome/browser/resources/ssl_roadblock.html#newcode99 chrome/browser/resources/ssl_roadblock.html:99: <button i18n-content="proceed" onclick="sendCommand(1);"> inline ...
8 years, 11 months ago (2012-01-24 19:49:13 UTC) #2
Dan Beam
http://codereview.chromium.org/9284010/diff/2001/chrome/browser/resources/ssl_roadblock.html File chrome/browser/resources/ssl_roadblock.html (right): http://codereview.chromium.org/9284010/diff/2001/chrome/browser/resources/ssl_roadblock.html#newcode43 chrome/browser/resources/ssl_roadblock.html:43: -webkit-transform: scaleX(-1); On 2012/01/24 19:49:13, Dan Beam wrote: > ...
8 years, 11 months ago (2012-01-24 20:22:28 UTC) #3
Evan Stade
are any of these comments meant for me to address?
8 years, 11 months ago (2012-01-24 22:05:25 UTC) #4
Dan Beam
On 2012/01/24 22:05:25, Evan Stade wrote: > are any of these comments meant for me ...
8 years, 11 months ago (2012-01-24 22:20:58 UTC) #5
Evan Stade
On 2012/01/24 22:20:58, Dan Beam wrote: > On 2012/01/24 22:05:25, Evan Stade wrote: > > ...
8 years, 11 months ago (2012-01-25 04:15:11 UTC) #6
Dan Beam
lgtm
8 years, 11 months ago (2012-01-25 04:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9284010/2001
8 years, 11 months ago (2012-01-25 04:18:25 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 05:54:15 UTC) #9
Change committed as 119019

Powered by Google App Engine
This is Rietveld 408576698