Add scoped_ptr<>::PassAs<>().

Add scoped_ptr<>::PassAs<>().

The new PassAs<>() method can be used to explicitly upcast scoped_ptr instances.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118958

[Wez, 2012-01-24 21:02:08]

LGTM for remoting/.

[darin (slow to review), 2012-01-24 21:17:53]

LGTM

http://codereview.chromium.org/9283028/diff/6001/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

http://codereview.chromium.org/9283028/diff/6001/base/memory/scoped_ptr.h#new...
base/memory/scoped_ptr.h:202: scoped_ptr<PassAsType> PassAs() {
Had you considered putting this in base/move.h alongside the definition of Pass?
 I'm not sure how to do it, so maybe it isn't even possible.

[Sergey Ulanov, 2012-01-24 21:55:18]

http://codereview.chromium.org/9283028/diff/6001/base/memory/scoped_ptr.h
File base/memory/scoped_ptr.h (right):

http://codereview.chromium.org/9283028/diff/6001/base/memory/scoped_ptr.h#new...
base/memory/scoped_ptr.h:202: scoped_ptr<PassAsType> PassAs() {
On 2012/01/24 21:17:53, darin wrote:
> Had you considered putting this in base/move.h alongside the definition of
Pass?
>  I'm not sure how to do it, so maybe it isn't even possible.

Yes, I considered it, but decided against it because it would be unsafe to allow
PassAs<>() for scoped_array. Specifically upcasting array pointers isn't safe
when sizes of parent and child classes differ.

[commit-bot: I haz the power, 2012-01-24 21:56:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9283028/6001

[commit-bot: I haz the power, 2012-01-25 00:33:07]

Change committed as 118958