Exposed Listen and Accept methods to plugin.

ppapi/api/private/ppb_tcp_server_socket_private.idl

Index: ppapi/api/private/ppb_tcp_server_socket_private.idl
diff --git a/ppapi/api/private/ppb_tcp_server_socket_private.idl b/ppapi/api/private/ppb_tcp_server_socket_private.idl
new file mode 100644
index 0000000000000000000000000000000000000000..8f2828505d64a1fd6df43476ba10a1cababaf8d2
--- /dev/null
+++ b/ppapi/api/private/ppb_tcp_server_socket_private.idl
@@ -0,0 +1,63 @@
+/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+/**
+ * This file defines the <code>PPB_TCPServerSocket_Private</code> interface.
+ */
+
+label Chrome {
+  M18 = 0.1
+};
+
+/**
+ * The <code>PPB_TCPServerSocket_Private</code> interface provides TCP
+ * server socket operations.
+ */
+interface PPB_TCPServerSocket_Private {
+  /**
+   * Allocates a TCP server socket resource and stores reference to it
+   * in |tcp_server_socket|.  |callback| is invoked when new
+   * PPB_TCP_ServerSocket_Private is successfully created or in the
+   * case of failure.
+   */
+  int32_t Create([in] PP_Instance instance,
+                 [out] PP_Resource tcp_server_socket,
+                 [in] PP_CompletionCallback callback);

[brettw, 2012/02/09 00:13:48]

We don't use callbacks in "create" functions because then the caller has no way
to cancel the callback by destroying the object. If you need async creation,
either put it in Listen() or add another function you have to call.

[ygorshenin1, 2012/02/09 15:00:10]

We decided that separate "Init" function will look unclear for users, the same
is for implementing initialization logic in Listen call. So, Create function
will return PP_Resource immediately, but proper initialization of corresponding
PPB_TCPServerSocket_Private will be completed only when callback is invoked.

[brettw, 2012/02/09 18:19:11]

I kind of know what you mean, but nothing else works like this, and I think it's
important we're consistent.

Are you sure we can't fold this initialization into Listen()? It seems like
every user of this API would do Create() and then Listen(), and Listen() is
already asynchronous. Folding this into Listen() would make it much easier to
program for since you now get a single event when it's ready rather than having
to write a state machine to start listening.

[ygorshenin1, 2012/02/09 18:44:27]

Well, but how to distinguish errors in socket initialization and errors in
listen?

On 2012/02/09 18:19:11, brettw wrote:

[brettw, 2012/02/09 18:52:33]

That's true. What errors are you concerned about differentiating?

[ygorshenin1, 2012/02/09 19:13:07]

New socket can't be initialized if socket table is full. Already initialized
socket can't bind to local address if this address is busy. In both cases
user'll see PP_ERROR_FAILED as result.

On 2012/02/09 18:52:33, brettw wrote:

[ygorshenin1, 2012/02/10 13:27:40]

Done.

+
+  /**
+   * Determines if a given resource is TCP server socket.
+   */
+  PP_Bool IsTCPServerSocket([in] PP_Resource resource);
+
+  /**
+   * Binds |tcp_server_socket| to the address given by |addr| and
+   * starts listening.  The |backlog| argument defines the maximum
+   * length to which the queue of pending connections may
+   * grow. |callback| is invoked when |tcp_server_socket| is ready to
+   * accept incoming connections or in the case of failure.
+   */
+  int32_t Listen([in] PP_Resource tcp_server_socket,
+                 [in] PP_NetAddress_Private addr,
+                 [in] int32_t backlog,
+                 [in] PP_CompletionCallback callback);
+
+  /**
+   * Accepts single connection, creates instance of
+   * PPB_TCPSocket_Private and stores reference to it in
+   * |tcp_socket|. |callback| is invoked when connection is accepted
+   * or in the case of failure. This method can be called only after
+   * succesfull Listen call on |tcp_server_socket|.
+   */
+  int32_t Accept([in] PP_Resource tcp_server_socket,
+                 [out] PP_Resource tcp_socket,
+                 [in] PP_CompletionCallback callback);
+
+  /**
+   * Cancels all pending callbacks reporting PP_Error_Aborted and

[yzshen1, 2012/02/09 02:31:50]

PP_ERROR_ABORTED, please.

[ygorshenin1, 2012/02/09 15:00:10]

Done.

+   * closes the socket. Note: this method is implicitly called when
+   * server socket is destroyed.
+   */
+  void StopListening([in] PP_Resource tcp_server_socket);
+};