Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 9283009: Adding GetProcId unittest (Closed)

Created:
8 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Adding GetProcId unittest - I want to refactor the windows version. But first I need a test. BUG=none TEST=yes it is. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119201

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M base/process_util_unittest.cc View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
Evan sorry to burden you but it is very simple and the others have either ...
8 years, 11 months ago (2012-01-24 04:52:19 UTC) #1
Evan Martin
LGTM never apologize for writing more tests! :D http://codereview.chromium.org/9283009/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): http://codereview.chromium.org/9283009/diff/1/base/process_util_unittest.cc#newcode175 base/process_util_unittest.cc:175: #if ...
8 years, 11 months ago (2012-01-24 16:30:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/9283009/5001
8 years, 11 months ago (2012-01-26 04:20:34 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-26 06:33:03 UTC) #4
Change committed as 119201

Powered by Google App Engine
This is Rietveld 408576698