Issue 9281011: [Mac] In PlatformThread::CurrentId(), use pthread_self() instead of mach_thread_self().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9281011: [Mac] In PlatformThread::CurrentId(), use pthread_self() instead of mach_thread_self(). (Closed)

Created:
8 years, 11 months ago by Robert Sesek

Modified:
8 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] In PlatformThread::CurrentId(), use pthread_self() instead of mach_thread_self(). BUG=105513 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118780

Patch Set 3 : nit #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
M	base/threading/platform_thread.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	base/threading/platform_thread_posix.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	base/threading/worker_pool_posix_unittest.cc	View	1 2	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM allays https://chromiumcodereview.appspot.com/9281011/diff/8001/base/threading/worker_pool_posix_unittest.cc File base/threading/worker_pool_posix_unittest.cc (right): https://chromiumcodereview.appspot.com/9281011/diff/8001/base/threading/worker_pool_posix_unittest.cc#newcode245 base/threading/worker_pool_posix_unittest.cc:245: // joined, the next-detached thread can get ...

8 years, 11 months ago (2012-01-23 22:57:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9281011/8004

8 years, 11 months ago (2012-01-24 00:15:10 UTC) #5

Change committed as 118780

Expand Messages | Collapse Messages

Issue 9281011: [Mac] In PlatformThread::CurrentId(), use pthread_self() instead of mach_thread_self(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix the test #

Patch Set 3 : nit #

Messages