Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: remoting/client/frame_consumer.h

Issue 9277001: Replace RectVectors with SkRegions in Decoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_CLIENT_FRAME_CONSUMER_H_ 5 #ifndef REMOTING_CLIENT_FRAME_CONSUMER_H_
6 #define REMOTING_CLIENT_FRAME_CONSUMER_H_ 6 #define REMOTING_CLIENT_FRAME_CONSUMER_H_
7 7
8 #include "remoting/base/decoder.h" // For UpdatedRects 8 #include "remoting/base/decoder.h" // For UpdatedRects
9 9
10 namespace remoting { 10 namespace remoting {
(...skipping 23 matching lines...) Expand all
34 // corresponding call ReleaseFrame(scoped_refptr<VideoFrame>* frame_out. 34 // corresponding call ReleaseFrame(scoped_refptr<VideoFrame>* frame_out.
35 virtual void AllocateFrame(media::VideoFrame::Format format, 35 virtual void AllocateFrame(media::VideoFrame::Format format,
36 const SkISize& size, 36 const SkISize& size,
37 scoped_refptr<media::VideoFrame>* frame_out, 37 scoped_refptr<media::VideoFrame>* frame_out,
38 const base::Closure& done) = 0; 38 const base::Closure& done) = 0;
39 39
40 virtual void ReleaseFrame(media::VideoFrame* frame) = 0; 40 virtual void ReleaseFrame(media::VideoFrame* frame) = 0;
41 41
42 // OnPartialFrameOutput() is called every time at least one rectangle of 42 // OnPartialFrameOutput() is called every time at least one rectangle of
43 // output is produced. The |frame| is guaranteed to have valid data for every 43 // output is produced. The |frame| is guaranteed to have valid data for every
44 // region included in the |rects| list. 44 // region included in the |rects| list.
Sergey Ulanov 2012/01/23 19:59:54 s/rects/region/
Wez 2012/01/23 21:37:23 Done.
45 // 45 //
46 // Both |frame| and |rects| are guaranteed to be valid until the |done| 46 // Both |frame| and |region| are guaranteed to be valid until the |done|
47 // callback is invoked. 47 // callback is invoked.
48 virtual void OnPartialFrameOutput(media::VideoFrame* frame, 48 virtual void OnPartialFrameOutput(media::VideoFrame* frame,
49 RectVector* rects, 49 SkRegion* region,
Sergey Ulanov 2012/01/23 19:59:54 should this be a const ref?
Wez 2012/01/23 21:37:23 Probably. However, I think the FrameConsumer API
50 const base::Closure& done) = 0; 50 const base::Closure& done) = 0;
51 51
52 private: 52 private:
53 DISALLOW_COPY_AND_ASSIGN(FrameConsumer); 53 DISALLOW_COPY_AND_ASSIGN(FrameConsumer);
54 }; 54 };
55 55
56 } // namespace remoting 56 } // namespace remoting
57 57
58 #endif // REMOTING_CLIENT_FRAME_CONSUMER_H_ 58 #endif // REMOTING_CLIENT_FRAME_CONSUMER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698