Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 9271084: Revert 119306 - Turn web intents build flag on. (Closed)

Created:
8 years, 11 months ago by Greg Billock
Modified:
8 years, 11 months ago
Reviewers:
jam, James Hawkins, sky
CC:
chromium-reviews, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org
Visibility:
Public.

Description

Revert 119306 - Turn web intents build flag on. Move the command-line flag to default-on. (Revert of 119284 : https://chromiumcodereview.appspot.com/9212036) IN CASE OF FIRE, PULL THIS HANDLE! If web intents needs to be disabled, revert this change. R=jhawkins@chromium.org BUG=111135 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M build/common.gypi View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/intents/intent_injector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Greg Billock
8 years, 11 months ago (2012-01-26 23:47:51 UTC) #1
Greg Billock
On 2012/01/26 23:47:51, Greg Billock wrote: Diff from this change to https://chromiumcodereview.appspot.com/9212036 is in the ...
8 years, 11 months ago (2012-01-26 23:51:08 UTC) #2
James Hawkins
8 years, 11 months ago (2012-01-26 23:51:47 UTC) #3
sky
LGTM
8 years, 11 months ago (2012-01-27 00:01:24 UTC) #4
James Hawkins
oops, thought I pressed it. LGTM
8 years, 11 months ago (2012-01-27 00:03:23 UTC) #5
jam
lgtm in the future, please first upload a revert before fixes, then upload a fix. ...
8 years, 11 months ago (2012-01-27 00:13:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/9271084/1
8 years, 11 months ago (2012-01-27 06:14:25 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-27 09:36:13 UTC) #8
Change committed as 119423

Powered by Google App Engine
This is Rietveld 408576698