Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 9271077: common.gypi: move harfbuzz-NG setting out into harfbuzz project (Closed)

Created:
8 years, 11 months ago by Evan Martin
Modified:
8 years, 11 months ago
Reviewers:
Nico, bashi
CC:
chromium-reviews
Visibility:
Public.

Description

common.gypi: move harfbuzz-NG setting out into harfbuzz project Less code in the central gyp file, more code near where it's used. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
8 years, 11 months ago (2012-01-26 22:41:01 UTC) #1
Nico
lgtm
8 years, 11 months ago (2012-01-26 22:48:02 UTC) #2
bashi
lgtm On 2012/01/26 22:48:02, Nico wrote: > lgtm
8 years, 11 months ago (2012-01-26 23:30:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9271077/1
8 years, 11 months ago (2012-01-27 00:12:00 UTC) #4
commit-bot: I haz the power
8 years, 11 months ago (2012-01-27 02:44:01 UTC) #5
Change committed as 119348

Powered by Google App Engine
This is Rietveld 408576698